Skip to content

KAFKA-13030 FindCoordinators batching causes slow poll when requestin… #10963

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
chia7712 wants to merge 2 commits into from
Closed

KAFKA-13030 FindCoordinators batching causes slow poll when requestin… #10963

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
ec6fbb2
KAFKA-13030 FindCoordinators batching causes slow poll when requestin…
chia7712 Jul 2, 2021
23b189c
add unit test
chia7712 Jul 4, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 3 additions & 2 deletions clients/src/main/java/org/apache/kafka/clients/consumer/internals/AbstractCoordinator.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -30,6 +30,7 @@
import org.apache.kafka.common.errors.MemberIdRequiredException;
import org.apache.kafka.common.errors.RebalanceInProgressException;
import org.apache.kafka.common.errors.RetriableException;
import org.apache.kafka.common.errors.TimeoutException;
import org.apache.kafka.common.errors.UnknownMemberIdException;
import org.apache.kafka.common.message.FindCoordinatorRequestData;
import org.apache.kafka.common.message.HeartbeatRequestData;
Expand Down Expand Up @@ -887,8 +888,8 @@ public void onFailure(RuntimeException e, RequestFuture<Void> future) {

if (e instanceof NoBatchedFindCoordinatorsException) {
batchFindCoordinator = false;
clearFindCoordinatorFuture();
lookupCoordinator();
// make a fast failure to send next request without batching
super.onFailure(new TimeoutException(e), future);
return;
}
if (!(e instanceof RetriableException)) {
Expand Down
19 changes: 19 additions & 0 deletions ...ts/src/test/java/org/apache/kafka/clients/consumer/internals/AbstractCoordinatorTest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,6 +18,7 @@

import org.apache.kafka.clients.GroupRebalanceConfig;
import org.apache.kafka.clients.MockClient;
import org.apache.kafka.clients.NodeApiVersions;
import org.apache.kafka.clients.consumer.OffsetResetStrategy;
import org.apache.kafka.common.Node;
import org.apache.kafka.common.errors.AuthenticationException;
Expand All @@ -35,6 +36,7 @@
import org.apache.kafka.common.message.SyncGroupResponseData;
import org.apache.kafka.common.metrics.KafkaMetric;
import org.apache.kafka.common.metrics.Metrics;
import org.apache.kafka.common.protocol.ApiKeys;
import org.apache.kafka.common.protocol.Errors;
import org.apache.kafka.common.requests.AbstractRequest;
import org.apache.kafka.common.requests.FindCoordinatorResponse;
Expand All @@ -55,6 +57,7 @@
import org.apache.kafka.test.TestUtils;
import org.junit.jupiter.api.AfterEach;
import org.junit.jupiter.api.Test;
import org.junit.jupiter.api.Timeout;

import java.nio.ByteBuffer;
import java.util.Arrays;
Expand Down Expand Up @@ -1028,6 +1031,22 @@ public void testLookupCoordinator() {
assertNotSame(future, coordinator.lookupCoordinator(), "New request not sent after previous completed");
}

@Timeout(10)
@Test
public void pollShouldBeDoneByNoBatchedFindCoordinatorsException() throws InterruptedException {
setupCoordinator();
mockClient.setNodeApiVersions(NodeApiVersions.create(ApiKeys.FIND_COORDINATOR.id, (short) 3, (short) 3));
RequestFuture<Void> future = coordinator.lookupCoordinator();
assertFalse(future.isDone());
// first response is replaced by UnsupportedVersionException
mockClient.prepareResponse(groupCoordinatorResponse(node, Errors.NONE));
// second response is what mock client pass to network client
mockClient.prepareResponse(groupCoordinatorResponse(node, Errors.NONE));
coordinator.ensureCoordinatorReady(mockTime.timer(10));
assertTrue(future.isDone());
assertTrue(future.failed());
}

@Test
public void testWakeupAfterJoinGroupSent() throws Exception {
setupCoordinator();
Expand Down