KAFKA-12648: minor followup from Pt. 2 and some new tests#11146
Merged
ableegoldman merged 3 commits intoapache:trunkfrom Jul 30, 2021
Merged
KAFKA-12648: minor followup from Pt. 2 and some new tests#11146ableegoldman merged 3 commits intoapache:trunkfrom
ableegoldman merged 3 commits intoapache:trunkfrom
Conversation
… 3 refactoring up front, plus test for IQ
Member
Author
|
also cc @wcarlson5 |
wcarlson5
approved these changes
Jul 30, 2021
Contributor
wcarlson5
left a comment
wcarlson5
left a comment
There was a problem hiding this comment.
LGTM thanks for the clean up and extra tests!
| } | ||
|
|
||
| /** | ||
| * @return true iff any of the topologies have a global topology |
Contributor
There was a problem hiding this comment.
do you mean if and only if by iff?
guozhangwang
approved these changes
Jul 30, 2021
Contributor
guozhangwang
left a comment
guozhangwang
left a comment
There was a problem hiding this comment.
Made a pass on the added tests. LGTM!
Member
Author
|
Merged to trunk |
xdgrulez
pushed a commit
to xdgrulez/kafka
that referenced
this pull request
Dec 22, 2021
Addresses the handful of remaining feedback from Pt. 2, plus adds two new tests: one verifying a multi-topology application with a FKJ and its internal topics, another to make sure IQ works with named topologies (though note that there is a bit more work left for IQ to be fully supported, will be tackled after Pt. 3 Reviewers: Guozhang Wang <guozhang@confluent.io>, Walker Carlson <wcarlson@confluent.io>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Addresses the handful of remaining feedback from Pt. 2, plus adds two new tests: one verifying a multi-topology application with a FKJ and its internal topics, another to make sure IQ works with named topologies (though note that there is a bit more work left for IQ to be fully supported, will be tackled after Pt. 3