KAFKA-13068: Rename Log to UnifiedLog#11154
Merged
junrao merged 5 commits intoapache:trunkfrom Aug 12, 2021
Merged
Conversation
Contributor
Author
ccding
approved these changes
Jul 31, 2021
kowshik
force-pushed
the
KAFKA-13068_rename_Log_to_UnifiedLog
branch
from
5a85097 to
57a8bc3
Compare
kowshik
force-pushed
the
KAFKA-13068_rename_Log_to_UnifiedLog
branch
from
61ae17c to
360d62b
Compare
Contributor
Author
|
@junrao Thanks for the review! I've fixed the build failure and uploaded 6d30c102a4816803f51c5b2c2350aa75b51238f2. We can wait for CI to pass. |
kowshik
force-pushed
the
KAFKA-13068_rename_Log_to_UnifiedLog
branch
from
6d30c10 to
46092a8
Compare
Contributor
Author
|
@junrao I checked CI results. The build has passed and the failing tests don't look related to this PR. |
xdgrulez
pushed a commit
to xdgrulez/kafka
that referenced
this pull request
Dec 22, 2021
In this PR, I've renamed kafka.log.Log to kafka.log.UnifiedLog. With the advent of KIP-405, going forward the existing Log class would present a unified view of local and tiered log segments, so we rename it to UnifiedLog. The motivation for this PR is also the same as outlined in this design document: https://docs.google.com/document/d/1dQJL4MCwqQJSPmZkVmVzshFZKuFy_bCPtubav4wBfHQ/edit. This PR is a follow-up to apache#10280 where we had refactored the Log layer introducing a new kafka.log.LocalLog class. Note: the Log class name had to be hardcoded to ensure metrics are defined under the Log class (for backwards compatibility). Please refer to the newly introduced UnifiedLog.metricName() method. Reviewers: Cong Ding <cong@ccding.com>, Satish Duggana <satishd@apache.org>, Jun Rao <junrao@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In this PR, I've renamed
kafka.log.Logtokafka.log.UnifiedLog. With the advent of KIP-405, going forward the existingLogclass would present a unified view of local and tiered log segments, so we rename it toUnifiedLog. The motivation for this PR is also the same as outlined in this design document: https://docs.google.com/document/d/1dQJL4MCwqQJSPmZkVmVzshFZKuFy_bCPtubav4wBfHQ/edit.This PR is a follow-up to #10280 where we had refactored the Log layer introducing a new
kafka.log.LocalLogclass.Note: the
Logclass name had to be hardcoded to ensure metrics are defined under theLogclass (for backwards compatibility). Please refer to the newly introducedUnifiedLog.metricName()method.Tests:
Relying on existing unit & integration tests to surface any regressions.