HOTFIX: fix backport of #11248 by future-proofing the EmbeddedKafkaCluster#11257
Merged
ableegoldman merged 2 commits intoapache:2.8from Aug 25, 2021
Conversation
Member
Author
This was referenced Aug 25, 2021
3 tasks
showuon
approved these changes
Aug 25, 2021
Member
showuon
left a comment
showuon
left a comment
There was a problem hiding this comment.
LGTM! And it also can avoid further backport issue. Nice!
Member
Author
|
Failures are unrelated are known to be flaky on older branches ( |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A backport of #11248 broke the 2.8 build due to usage of the
EmbeddedKafkaCluster#stopmethod, which used to be private. It seems we made this public when we upgraded to JUnit5 on the 3.0 branch and had to remove the ExternalResource that was previously responsible for callingstart()andstop()for this class using the no-longer-available@ClassRuleannotation.Rather than adapt this test to the 2.8 style by migrating it to use
@ClassRuleas well, I opted to just make thestop() method public as well (since its analoguestart()` has always been public anyways). This should hopefully prevent any future backports that include integration tests from having to manually go in and adapt the test, or accidentally break the build as happened here.