MINOR: add to empty, remove then add different test#11258
Closed
wcarlson5 wants to merge 1 commit intoapache:trunkfrom
wcarlson5:remove_race
Closed
MINOR: add to empty, remove then add different test#11258wcarlson5 wants to merge 1 commit intoapache:trunkfrom wcarlson5:remove_race
wcarlson5 wants to merge 1 commit intoapache:trunkfrom
wcarlson5:remove_race
Conversation
Member
|
Sounds like this is waiting on the blocking functionality coming in Pt. 4 -- thanks for the test, do you want to just leave this PR until Pt. 4 is merged and then make sure it passes? Alternatively I can copy this over to the Pt. 4 PR and merge it with that |
Contributor
Author
|
@ableegoldman whatever works best for you |
ableegoldman
added a commit
to ableegoldman/kafka
that referenced
this pull request
Sep 19, 2021
Member
|
Copied over to the Pt. 4 PR so we can make sure this passes by the time Pt. 4 is merged |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
add a test for named topology
Committer Checklist (excluded from commit message)