KAFKA-13273: Add support for Java 17#11296
Merged
ijuma merged 21 commits intoapache:trunkfrom Sep 6, 2021
Merged
Conversation
Java 17 is at release candidate stage and it will be a LTS release (first one since Java 11).
Member
Author
|
I expect that this will require some work before it can be merged. |
The former was removed from Java 17
I will remove again before merging.
…k.internal.util.random
ijuma
changed the title
ijuma
changed the title
ijuma
commented
Sep 5, 2021
ijuma
commented
Sep 5, 2021
Member
Author
|
Build 6 (including Java 16) passed: https://ci-builds.apache.org/job/Kafka/job/kafka-pr/job/PR-11296/6/ I will now remove Java 16 from Jenkinsfile. |
Member
Author
Member
Author
|
And we have a green build. :) |
chia7712
approved these changes
Sep 6, 2021
Member
chia7712
left a comment
chia7712
left a comment
There was a problem hiding this comment.
This patch is great to me! a couple of comments below.
chia7712
approved these changes
Sep 6, 2021
xdgrulez
pushed a commit
to xdgrulez/kafka
that referenced
this pull request
Dec 22, 2021
Java 17 is at release candidate stage and it will be a LTS release once it's out (previous LTS release was Java 11). Details: * Replace Java 16 with Java 17 in Jenkins and Readme. * Replace `--illegal-access=permit` (which was removed from Java 17) with `--add-opens` for the packages we require internal access to. Filed KAFKA-13275 for updating the tests not to require `--add-opens` (where possible). * Update `release.py` to use JDK8. and JDK 17 (instead of JDK 8 and JDK 15). * Removed all but one Streams test from `testsToExclude`. The Connect test exclusion list remains the same. * Add notable change to upgrade.html * Upgrade to Gradle 7.2 as it's required for proper Java 17 support. * Upgrade mockito to 3.12.4 for better Java 17 support. * Adjusted `KafkaRaftClientTest` and `QuorumStateTest` not to require private access to `jdk.internal.util.random`. Reviewers: Manikumar Reddy <manikumar.reddy@gmail.com>, Chia-Ping Tsai <chia7712@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Java 17 is at release candidate stage and it will be a LTS release once
it's out (previous LTS release was Java 11).
Details:
--illegal-access=permit(which was removed from Java 17)with
--add-opensfor the packages we require internal access to.Filed KAFKA-13275 for updating the tests not to require
--add-opens(where possible).
release.pyto use JDK8. and JDK 17 (instead of JDK 8 and JDK 15).testsToExclude. TheConnect test exclusion list remains the same.
KafkaRaftClientTestandQuorumStateTestnot to requireprivate access to
jdk.internal.util.random.Committer Checklist (excluded from commit message)