MINOR: Add shebang to gradlewAll#11373
Merged
mimaison merged 1 commit intoapache:trunkfrom Oct 6, 2022
Merged
Conversation
Contributor
Author
|
@ijuma could you approve this change pls? Python based build executor died because of it: |
Contributor
Author
|
@granthenke , could you take a look as well? Thanks! |
viktorsomogyi
approved these changes
Oct 5, 2021
Contributor
|
@ijuma would you please quickly review this small pr? |
Contributor
Author
|
@ijuma I've added the same shebang as gradlew has to gradlewAll. Could you check it pls? 🥺 🎅 🎄 😄 |
Contributor
Author
Contributor
|
@mimaison would you please check this quickly? (I think the test failures are unrelated as this only affects the command line) |
guozhangwang
pushed a commit
to guozhangwang/kafka
that referenced
this pull request
Jan 25, 2023
Reviewers: Mickael Maison <mickael.maison@gmail.com>, Viktor Somogyi-Vass <viktorsomogyi@gmail.com>
rutvijmehta-harness
pushed a commit
to rutvijmehta-harness/kafka
that referenced
this pull request
Feb 9, 2024
Reviewers: Mickael Maison <mickael.maison@gmail.com>, Viktor Somogyi-Vass <viktorsomogyi@gmail.com>
rutvijmehta-harness
added a commit
to rutvijmehta-harness/kafka
that referenced
this pull request
Feb 9, 2024
Reviewers: Mickael Maison <mickael.maison@gmail.com>, Viktor Somogyi-Vass <viktorsomogyi@gmail.com> Co-authored-by: Andras Katona <41361962+akatona84@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
More detailed description of your change,
if necessary. The PR title and PR message become
the squashed commit message, so use a separate
comment to ping reviewers.
Summary of testing strategy (including rationale)
for the feature or bug fix. Unit and/or integration
tests are expected for any behaviour change and
system tests should be considered for larger changes.
Committer Checklist (excluded from commit message)