KAFKA-10543: Convert KTable joins to new PAPI#11412
Merged
vvcephei merged 16 commits intoapache:trunkfrom Nov 8, 2021
Merged
Conversation
jeqo
changed the title
Contributor
Author
|
cc @vvcephei |
vvcephei
reviewed
Nov 8, 2021
Contributor
There was a problem hiding this comment.
I think the forwarding type for a value getter should be <Void, Void>, right?
Contributor
Author
There was a problem hiding this comment.
Interesting. As far as I can see the value getters do not forward, so retricting the types could be an option.
At the moment though, these value getters are initialized as part of the processor itself, and changing this types would break things.
Do you think we should consider redesign this internal api inthe future as well?
Comment on lines
108
to
111
Contributor
There was a problem hiding this comment.
What's up with this? (and below)
Contributor
There was a problem hiding this comment.
Looks like this needs to be re-enabled.
Contributor
There was a problem hiding this comment.
Another disabled assertion.
jeqo
force-pushed
the
migrate-processor
branch
from
f29347a to
2ec187d
Compare
vvcephei
approved these changes
Nov 8, 2021
stanislavkozlovski
added a commit
to stanislavkozlovski/kafka
that referenced
this pull request
Nov 11, 2021
…ntegration-11-nov * ak/trunk: (15 commits) KAFKA-13429: ignore bin on new modules (apache#11415) KAFKA-12648: introduce TopologyConfig and TaskConfig for topology-level overrides (apache#11272) KAFKA-12487: Add support for cooperative consumer protocol with sink connectors (apache#10563) MINOR: Log client disconnect events at INFO level (apache#11449) MINOR: Remove topic null check from `TopicIdPartition` and adjust constructor order (apache#11403) KAFKA-13417; Ensure dynamic reconfigurations set old config properly (apache#11448) MINOR: Adding a constant to denote UNKNOWN leader in LeaderAndEpoch (apache#11477) KAFKA-10543: Convert KTable joins to new PAPI (apache#11412) KAFKA-12226: Commit source task offsets without blocking on batch delivery (apache#11323) KAFKA-13396: Allow create topic without partition/replicaFactor (apache#11429) ...
xdgrulez
pushed a commit
to xdgrulez/kafka
that referenced
this pull request
Dec 22, 2021
* Migrate KTable joins to new Processor API. * Migrate missing KTableProcessorSupplier implementations. * Replace KTableProcessorSupplier with new Processor API implementation. Reviewers: John Roesler <vvcephei@apache.org>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes:
Committer Checklist (excluded from commit message)