KAFKA-13436: Omitted BrokerTopicMetrics metrics in the documentation#11473
Merged
mimaison merged 8 commits intoapache:trunkfrom Jun 13, 2022
Merged
KAFKA-13436: Omitted BrokerTopicMetrics metrics in the documentation#11473mimaison merged 8 commits intoapache:trunkfrom
mimaison merged 8 commits intoapache:trunkfrom
Conversation
Closed
3 tasks
Contributor
Author
splett2
reviewed
Nov 9, 2021
Contributor
There was a problem hiding this comment.
seems like we're missing an explanation for what these metrics measure.
Member
There was a problem hiding this comment.
Yes let's try to include descriptions as above we recommend to graph and alert on these metrics
Contributor
Author
|
@splett2 Here is the fix. Reviewing the documentation, I found that 1. the other 'BrokerTopicMetrics' metrics are omitting |
Contributor
Author
|
As soon as this PR is merged, I will open a corresponding PR in |
dajac
reviewed
Nov 19, 2021
Contributor
Author
|
@dajac Here is the update; As you can see here, only |
dongjinleekr
force-pushed
the
feature/KAFKA-13436
branch
from
2927e6a to
4852135
Compare
dongjinleekr
force-pushed
the
feature/KAFKA-13436
branch
from
4852135 to
649a17d
Compare
Contributor
Author
|
@splett2 @mimaison Sorry for being late. Here is the fix. Not only rebasing onto the latest trunk, I carefully inspected the implementation of
|
dongjinleekr
force-pushed
the
feature/KAFKA-13436
branch
from
dddea0d to
d3c38f0
Compare
Contributor
Author
|
Rebased onto the latest trunk. |
mimaison
reviewed
Jun 7, 2022
Member
mimaison
left a comment
mimaison
left a comment
There was a problem hiding this comment.
Thanks @dongjinleekr for the PR. I left a few suggestions
…=([-.\w]+)' to the BrokerTopicMetrics metrics.
…okerTopicMetrics metrics.
1. Add description on all-topic metrics; these metrics are provided on both of per-topic, all-topic basis. (see: BrokerTopicStats#topicStats, BrokerTopicStats#allTopicsStats) - MessagesInPerSec - BytesInPerSec - BytesOutPerSec - ReplicationBytesInPerSec - ReplicationBytesOutPerSec - TotalProduceRequestsPerSec - TotalFetchRequestsPerSec - FailedProduceRequestsPerSec - FailedFetchRequestsPerSec - ProduceMessageConversionsPerSec - FetchMessageConversionsPerSec - BytesRejectedPerSec 2. Remove the 'topic' attribute from all-topic only metrics: - NoKeyCompactedTopicRecordsPerSec - InvalidMagicNumberRecordsPerSec - InvalidMessageCrcRecordsPerSec - InvalidOffsetOrSequenceRecordsPerSec - ReassignmentBytesOutPerSec - ReassignmentBytesInPerSec
dongjinleekr
force-pushed
the
feature/KAFKA-13436
branch
from
d3c38f0 to
a517fbf
Compare
Contributor
Author
|
@mimaison Here it is, with rebasing onto the latest trunk. 🙇 |
ableegoldman
added a commit
to confluentinc/kafka
that referenced
this pull request
Jun 14, 2022
CONFLUENT: Sync from apache/kafka trunk to confluentinc/kafka master (13 Jun 2022) apache/trunk: (7 commits) KAFKA-13891: reset generation when syncgroup failed with REBALANCE_IN…(apache#12140) KAFKA-10000: Exactly-once source tasks (apache#11780) KAFKA-13436: Omitted BrokerTopicMetrics metrics in the documentation (apache#11473) MINOR: Use Exit.addShutdownHook instead of directly adding hooks to R…(apache#12283) KAFKA-13846: Adding overloaded metricOrElseCreate method (apache#12121) KAFKA-13935 Fix static usages of IBP in KRaft mode (apache#12250) HOTFIX: null check keys of ProducerRecord when computing sizeInBytes (apache#12288) Conflicts: None
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I found this issue while working on KAFKA-13354.
As soon as this PR is approved, I will open a PR on the kafka-site also.
Committer Checklist (excluded from commit message)