Skip to content

KAFKA-13370: add unit test for offset-commit metrics#11509

Closed
showuon wants to merge 1 commit intoapache:trunkfrom
showuon:KAFKA-13370_ut
Closed

KAFKA-13370: add unit test for offset-commit metrics#11509
showuon wants to merge 1 commit intoapache:trunkfrom
showuon:KAFKA-13370_ut

Conversation

@showuon
Copy link
Copy Markdown
Member

@showuon showuon commented Nov 17, 2021

Follow up for #11413 (comment), to add tests for offset-commit metrics.

Committer Checklist (excluded from commit message)

  • Verify design and implementation
  • Verify test coverage and CI build status
  • Verify documentation (including upgrade notes)

@showuon
Copy link
Copy Markdown
Member Author

showuon commented Nov 17, 2021

@rhauch , per our discussion, here's the tests to be added. Thank you.

@showuon
Copy link
Copy Markdown
Member Author

showuon commented Nov 19, 2021

Failed tests are unrelated. Thank you.

    Build / JDK 17 and Scala 2.13 / kafka.admin.LeaderElectionCommandTest.[1] Type=Raft, Name=testTopicPartition, Security=PLAINTEXT
    Build / JDK 17 and Scala 2.13 / kafka.admin.LeaderElectionCommandTest.[1] Type=Raft, Name=testTopicPartition, Security=PLAINTEXT
    Build / JDK 8 and Scala 2.12 / kafka.admin.LeaderElectionCommandTest.[1] Type=Raft, Name=testAllTopicPartition, Security=PLAINTEXT
    Build / JDK 8 and Scala 2.12 / kafka.admin.LeaderElectionCommandTest.[1] Type=Raft, Name=testAllTopicPartition, Security=PLAINTEXT

@mimaison
Copy link
Copy Markdown
Member

Thanks @showuon for the PR. It looks good, can you rebase it?

@github-actions
Copy link
Copy Markdown

This PR is being marked as stale since it has not had any activity in 90 days. If you
would like to keep this PR alive, please leave a comment asking for a review. If the PR has
merge conflicts, update it with the latest from the base branch.

If you are having difficulty finding a reviewer, please reach out on the [mailing list](https://kafka.apache.org/contact).

If this PR is no longer valid or desired, please feel free to close it. If no activity occurs in the next 30 days, it will be automatically closed.

@github-actions github-actions Bot added the stale Stale PRs label Dec 25, 2024
@showuon showuon closed this Jan 9, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

stale Stale PRs

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants