KAFKA-13370: add unit test for offset-commit metrics#11509
Closed
showuon wants to merge 1 commit intoapache:trunkfrom
Closed
KAFKA-13370: add unit test for offset-commit metrics#11509showuon wants to merge 1 commit intoapache:trunkfrom
showuon wants to merge 1 commit intoapache:trunkfrom
Conversation
Member
Author
|
@rhauch , per our discussion, here's the tests to be added. Thank you. |
Member
Author
|
Failed tests are unrelated. Thank you. |
Member
|
Thanks @showuon for the PR. It looks good, can you rebase it? |
|
This PR is being marked as stale since it has not had any activity in 90 days. If you If you are having difficulty finding a reviewer, please reach out on the [mailing list](https://kafka.apache.org/contact). If this PR is no longer valid or desired, please feel free to close it. If no activity occurs in the next 30 days, it will be automatically closed. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow up for #11413 (comment), to add tests for offset-commit metrics.
Committer Checklist (excluded from commit message)