KAFKA-13242: Ensure UpdateFeatures is properly handled in KRaft#11522
Closed
dengziming wants to merge 2 commits intoapache:trunkfrom
Closed
KAFKA-13242: Ensure UpdateFeatures is properly handled in KRaft#11522dengziming wants to merge 2 commits intoapache:trunkfrom
dengziming wants to merge 2 commits intoapache:trunkfrom
Conversation
4c7314f to
ce0bcd3
Compare
Member
Author
|
Hello @cmccabe ,PTAL, thanks. |
mumrah
reviewed
Nov 23, 2021
Member
mumrah
left a comment
There was a problem hiding this comment.
@dengziming, thanks for the patch! I have many similar looking changes locally as part of my KIP-778 prototype. This is a good chunk to split out and get merged ahead of the other changes.
There are some possible changes to KIP-584 coming from that discussion, so let's see what happens there. I'll try to take a look at this next week (after thanksgiving).
ce0bcd3 to
3fe8be2
Compare
Member
|
@dengziming, we have a few changes to the feature flags coming in KIP-778. Let's hold off on merging this until the KIP is adopted. |
Member
Author
|
Thank you @mumrah , I am checking KIP-778 about this. |
Member
Author
|
See #12036 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
More detailed description of your change
This patch fixes several problems with the UpdateFeatures API in KRaft:
KafkaApis did not properly forward this request type to the controller.
ControllerApis did not handle the request type.
Some other small fixes.
Summary of testing strategy (including rationale)
Committer Checklist (excluded from commit message)