Skip to content

MINOR: MetadataShell should handle ProducerIdsRecord#11603

Merged
hachikuji merged 7 commits intoapache:trunkfrom
dengziming:add-producer-id
Feb 12, 2022
Merged

MINOR: MetadataShell should handle ProducerIdsRecord#11603
hachikuji merged 7 commits intoapache:trunkfrom
dengziming:add-producer-id

Conversation

@dengziming
Copy link
Copy Markdown
Member

@dengziming dengziming commented Dec 14, 2021

More detailed description of your change
We store producer IDs in broker snapshots in #11527, I think we could also add the ability to inspect it using MetadataShell.

Summary of testing strategy (including rationale)
I tested this locally:

[ Kafka Metadata Shell ]
>> cat /producerIds/broker
1
>> cat /producerIds/blockStart
0
>> cat /producerIds/blockEnd
999
>> 

Committer Checklist (excluded from commit message)

  • Verify design and implementation
  • Verify test coverage and CI build status
  • Verify documentation (including upgrade notes)

@dengziming
Copy link
Copy Markdown
Member Author

Hi, @cmccabe , this is a minor improvement similar to your PR #11527. PTAL.

@dengziming dengziming force-pushed the add-producer-id branch 2 times, most recently from 61478ad to 5b88573 Compare December 14, 2021 15:28
@dengziming
Copy link
Copy Markdown
Member Author

This change makes the MetadataShell generate the same output as what we get from zookeeper path "/latest_producer_id_block" added in #10504. ping @mumrah to have a look.

Copy link
Copy Markdown
Contributor

@hachikuji hachikuji left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the patch. Left a couple suggestions for consideration.

Comment thread shell/src/main/java/org/apache/kafka/shell/MetadataNodeManager.java Outdated
Comment thread shell/src/main/java/org/apache/kafka/shell/MetadataNodeManager.java Outdated
Comment thread shell/src/test/java/org/apache/kafka/shell/MetadataNodeManagerTest.java Outdated
Comment thread shell/src/main/java/org/apache/kafka/shell/MetadataNodeManager.java Outdated
Comment thread shell/src/main/java/org/apache/kafka/shell/MetadataNodeManager.java Outdated
Copy link
Copy Markdown
Contributor

@hachikuji hachikuji left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks for the patch!

@hachikuji hachikuji merged commit 076648e into apache:trunk Feb 12, 2022
@dengziming dengziming deleted the add-producer-id branch October 8, 2022 12:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants