Skip to content

KAFKA-13533: Clean up resources on failed connector and task startup#11608

Closed
C0urante wants to merge 2 commits intoapache:trunkfrom
C0urante:kafka-13533
Closed

KAFKA-13533: Clean up resources on failed connector and task startup#11608
C0urante wants to merge 2 commits intoapache:trunkfrom
C0urante:kafka-13533

Conversation

@C0urante
Copy link
Copy Markdown
Contributor

@C0urante C0urante commented Dec 16, 2021 •
edited
Loading

Jira

Introduces and leverages a new Closeables utility class that can be used to track accrued AutoCloseable objects via a try-with-resources block. Also switches the Worker class over to use Plugins::withClassLoader wherever possible.

Committer Checklist (excluded from commit message)

  • Verify design and implementation
  • Verify test coverage and CI build status
  • Verify documentation (including upgrade notes)

@C0urante C0urante mentioned this pull request Jun 14, 2022
Merged
@C0urante C0urante changed the title KAFKA-13533: Clean up resources on failed task startup KAFKA-13533: Clean up resources on failed connector and task startup Jul 15, 2022
@C0urante
Copy link
Copy Markdown
Contributor Author

C0urante commented Jul 15, 2022 •
edited
Loading

@tombentley FYI, I've finished rebasing this.

yeoncheol-jang
yeoncheol-jang reviewed Jul 30, 2022
View reviewed changes
Comment thread connect/runtime/src/main/java/org/apache/kafka/connect/util/Closeables.java Outdated
yeoncheol-jang
yeoncheol-jang approved these changes Aug 1, 2022
View reviewed changes
Copy link
Copy Markdown

@yeoncheol-jang yeoncheol-jang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't have any authority but no additional opinion for this. 👍🏼

@C0urante C0urante marked this pull request as draft June 6, 2023 17:18
@C0urante
Copy link
Copy Markdown
Contributor Author

C0urante commented Jun 6, 2023

Downgrading to a draft until I can revisit and fix the merge conflicts.

@C0urante C0urante mentioned this pull request Dec 12, 2023
Merged
3 tasks
@github-actions
Copy link
Copy Markdown

github-actions Bot commented Dec 25, 2024

This PR is being marked as stale since it has not had any activity in 90 days. If you
would like to keep this PR alive, please leave a comment asking for a review. If the PR has
merge conflicts, update it with the latest from the base branch.

If you are having difficulty finding a reviewer, please reach out on the [mailing list](https://kafka.apache.org/contact).

If this PR is no longer valid or desired, please feel free to close it. If no activity occurs in the next 30 days, it will be automatically closed.

@github-actions github-actions Bot added the stale Stale PRs label Dec 25, 2024
@github-actions
Copy link
Copy Markdown

github-actions Bot commented Jan 25, 2025

This PR has been closed since it has not had any activity in 120 days. If you feel like this
was a mistake, or you would like to continue working on it, please feel free to re-open the
PR and ask for a review.

@github-actions github-actions Bot added the closed-stale PRs that were closed due to inactivity label Jan 25, 2025
@github-actions github-actions Bot closed this Jan 25, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@yeoncheol-jang yeoncheol-jang yeoncheol-jang approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

closed-stale PRs that were closed due to inactivity connect stale Stale PRs

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@C0urante @yeoncheol-jang @kkonstantine