MINOR: deleteHorizonMs update to documentation and DumpLogSegments tool#11694
Merged
hachikuji merged 3 commits intoapache:trunkfrom Feb 5, 2022
Merged
Conversation
hachikuji
reviewed
Jan 21, 2022
Contributor
hachikuji
left a comment
hachikuji
left a comment
There was a problem hiding this comment.
Thanks. While we're updating documentation, there are some comments about the old FirstTimestamp field in DefaultRecordBatch that seem outdated.
hachikuji
reviewed
Jan 22, 2022
| * There is no similar need to preserve the timestamp from the original batch after compaction. The BaseTimestamp | ||
| * field therefore always reflects the timestamp of the first record in the batch. If the batch is empty, the | ||
| * FirstTimestamp will be set to -1 (NO_TIMESTAMP). | ||
| * BaseTimestamp will be set to -1 (NO_TIMESTAMP). |
Contributor
There was a problem hiding this comment.
The comment is still inaccurate, no? The base timestamp does not always reflect the timestamp of the first record in the batch.
Contributor
Author
There was a problem hiding this comment.
you are right, thanks for the catch. I've revised the comments to be accurate about BaseTimestamp after compaction.
hachikuji
approved these changes
Feb 4, 2022
Contributor
hachikuji
left a comment
hachikuji
left a comment
There was a problem hiding this comment.
LGTM. Thanks for the patch!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR updates the documentation and tooling to match the changes made in #10914
In the documentation, changes include the adding the new attribute and updating field names.
In the DumpLogSegments tool, when record batch information is printed, it will also include what the value of deleteHorizonMs is (
OptionalLong.emptyorOptionalLong[123456])