Skip to content

MINOR: remove redundant argument in logging#11719

Merged
chia7712 merged 2 commits intoapache:trunkfrom
chia7712:MINOR-11719
Jan 30, 2022
Merged

MINOR: remove redundant argument in logging#11719
chia7712 merged 2 commits intoapache:trunkfrom
chia7712:MINOR-11719

Conversation

@chia7712
Copy link
Copy Markdown
Member

related to #11451

Committer Checklist (excluded from commit message)

  • Verify design and implementation
  • Verify test coverage and CI build status
  • Verify documentation (including upgrade notes)

@showuon
Copy link
Copy Markdown
Member

showuon commented Jan 30, 2022

Oh, my bad! Good catch @chia7712 !
Please help update the PR to remove the generation argument.
Thanks.

Copy link
Copy Markdown
Member

@showuon showuon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks for the patch!

Copy link
Copy Markdown
Member

@dajac dajac left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@chia7712 chia7712 merged commit 98e8608 into apache:trunk Jan 30, 2022
@chia7712 chia7712 deleted the MINOR-11719 branch March 25, 2024 15:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants