KAFKA-13542: add rebalance reason in Kafka Streams#11804
Merged
cadonna merged 3 commits intoapache:trunkfrom Feb 28, 2022
Merged
KAFKA-13542: add rebalance reason in Kafka Streams#11804cadonna merged 3 commits intoapache:trunkfrom
cadonna merged 3 commits intoapache:trunkfrom
Conversation
Contributor
Author
|
Hi @ableegoldman , can you take a look at this easy one? |
Contributor
Author
|
Hi @showuon , I saw lots of checks failed here and in other merged PRs. Is |
Member
|
@lihaosky , Failed tests are flaky and unrelated. Also failed in trunk sometimes: So, don't worry! I'll wait for another week to see if there are other people want to have another review. Thanks. |
ableegoldman
pushed a commit
that referenced
this pull request
Mar 10, 2022
…11873) This reverts commit 2ccc834. This reverts commit 2ccc834. We were seeing serious regressions in our state heavy benchmarks. We saw that our state heavy benchmarks were experiencing a really bad regression. The State heavy benchmarks runs with rolling bounces with 10 nodes. We regularly saw this exception: java.lang.OutOfMemoryError: Java heap space I ran through a git bisect and found this commit. We verified that the commit right before did not have the same issues as this one did. I then reverted the problematic commit and ran the benchmarks again on this commit and did not see any more issues. We are still looking into the root cause, but for now since this isn't a critical improvement so we can remove it temporarily. Reviewers: Bruno Cadonna <cadonna@confluent.io>, Anna Sophie Blee-Goldman <ableegoldman@apache.org>, David Jacot <djacot@confluent.io>, Ismael Juma <ismael@confluent.io>
wcarlson5
added a commit
to confluentinc/kafka
that referenced
this pull request
Mar 22, 2022
)" (apache#11873) This reverts commit 2ccc834. This reverts commit 2ccc834. We were seeing serious regressions in our state heavy benchmarks. We saw that our state heavy benchmarks were experiencing a really bad regression. The State heavy benchmarks runs with rolling bounces with 10 nodes. We regularly saw this exception: java.lang.OutOfMemoryError: Java heap space I ran through a git bisect and found this commit. We verified that the commit right before did not have the same issues as this one did. I then reverted the problematic commit and ran the benchmarks again on this commit and did not see any more issues. We are still looking into the root cause, but for now since this isn't a critical improvement so we can remove it temporarily. Reviewers: Bruno Cadonna <cadonna@confluent.io>, Anna Sophie Blee-Goldman <ableegoldman@apache.org>, David Jacot <djacot@confluent.io>, Ismael Juma <ismael@confluent.io>
wcarlson5
added a commit
to confluentinc/kafka
that referenced
this pull request
Mar 28, 2022
)" (apache#11873) This reverts commit 2ccc834. This reverts commit 2ccc834. We were seeing serious regressions in our state heavy benchmarks. We saw that our state heavy benchmarks were experiencing a really bad regression. The State heavy benchmarks runs with rolling bounces with 10 nodes. We regularly saw this exception: java.lang.OutOfMemoryError: Java heap space I ran through a git bisect and found this commit. We verified that the commit right before did not have the same issues as this one did. I then reverted the problematic commit and ran the benchmarks again on this commit and did not see any more issues. We are still looking into the root cause, but for now since this isn't a critical improvement so we can remove it temporarily. Reviewers: Bruno Cadonna <cadonna@confluent.io>, Anna Sophie Blee-Goldman <ableegoldman@apache.org>, David Jacot <djacot@confluent.io>, Ismael Juma <ismael@confluent.io>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add rebalance reason in Kafka Streams.
Committer Checklist (excluded from commit message)