Skip to content

KAFKA-13698; KRaft authorizer should use host address instead of name#11807

Merged
hachikuji merged 2 commits intoapache:trunkfrom
hachikuji:KAFKA-13698
Feb 26, 2022
Merged

KAFKA-13698; KRaft authorizer should use host address instead of name#11807
hachikuji merged 2 commits intoapache:trunkfrom
hachikuji:KAFKA-13698

Conversation

@hachikuji
Copy link
Copy Markdown
Contributor

Use InetAddress.getHostAddress in StandardAuthorizer instead of InetAddress.getHostName.

Committer Checklist (excluded from commit message)

  • Verify design and implementation
  • Verify test coverage and CI build status
  • Verify documentation (including upgrade notes)

@hachikuji
Copy link
Copy Markdown
Contributor Author

New integration test is not working on jenkins. I was afraid of that. I'll have to see if there's a better approach.

Copy link
Copy Markdown
Contributor

@cmccabe cmccabe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@cmccabe
Copy link
Copy Markdown
Contributor

cmccabe commented Feb 25, 2022

@hachikuji : looks like AuthorizerIntegrationTest#testHostAddressBasedAcls needs to be fixed.

@cmccabe
Copy link
Copy Markdown
Contributor

cmccabe commented Feb 25, 2022

[2022-02-25T22:07:29.188Z] AuthorizerIntegrationTest > testHostAddressBasedAcls(String) > kafka.api.AuthorizerIntegrationTest.testHostAddressBasedAcls(String)[2] FAILED
[2022-02-25T22:07:29.188Z]     org.opentest4j.AssertionFailedError: expected: <NONE> but was: <TOPIC_AUTHORIZATION_FAILED>
[2022-02-25T22:07:29.188Z]         at app//org.junit.jupiter.api.AssertionUtils.fail(AssertionUtils.java:55)
[2022-02-25T22:07:29.188Z]         at app//org.junit.jupiter.api.AssertionUtils.failNotEqual(AssertionUtils.java:62)
[2022-02-25T22:07:29.188Z]         at app//org.junit.jupiter.api.AssertEquals.assertEquals(AssertEquals.java:182)
[2022-02-25T22:07:29.188Z]         at app//org.junit.jupiter.api.AssertEquals.assertEquals(AssertEquals.java:177)
[2022-02-25T22:07:29.188Z]         at app//org.junit.jupiter.api.Assertions.assertEquals(Assertions.java:1141)
[2022-02-25T22:07:29.188Z]         at app//kafka.api.AuthorizerIntegrationTest.testHostAddressBasedAcls(AuthorizerIntegrationTest.scala:2434)

@hachikuji hachikuji merged commit 5f91aa7 into apache:trunk Feb 26, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants