KAFKA-13281: list all named topologies#11808
Merged
ableegoldman merged 2 commits intoapache:trunkfrom Feb 26, 2022
wcarlson5:list_all_topologies
Merged
KAFKA-13281: list all named topologies#11808ableegoldman merged 2 commits intoapache:trunkfrom wcarlson5:list_all_topologies
ableegoldman merged 2 commits intoapache:trunkfrom
wcarlson5:list_all_topologies
Conversation
2 tasks
| } | ||
|
|
||
| public Collection<NamedTopology> getAllTopologies() { | ||
| return getAllTopologies(); |
Member
There was a problem hiding this comment.
this looks like an infinite loop?
Contributor
Author
There was a problem hiding this comment.
oops. I though I was calling that on topology metadata. Fixed!
ableegoldman
approved these changes
Feb 26, 2022
Member
ableegoldman
left a comment
ableegoldman
left a comment
There was a problem hiding this comment.
LGTM, and all test failures are unrelated/known flaky so merging to trunk
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
List all the named topologies that have been added to this client
Committer Checklist (excluded from commit message)