Skip to content

KAFKA-13281: can remove topologies while in a created state#11810

Merged
ableegoldman merged 1 commit intoapache:trunkfrom
wcarlson5:Can_remove_in_created_state
Feb 26, 2022
Merged

KAFKA-13281: can remove topologies while in a created state#11810
ableegoldman merged 1 commit intoapache:trunkfrom
wcarlson5:Can_remove_in_created_state

Conversation

@wcarlson5
Copy link
Copy Markdown
Contributor

We should be able to change the topologies in a created state. This should include removing them.

Committer Checklist (excluded from commit message)

  • Verify design and implementation
  • Verify test coverage and CI build status
  • Verify documentation (including upgrade notes)

Copy link
Copy Markdown
Member

@ableegoldman ableegoldman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM although would prefer this be a unit test on its own instead of adding to an integration test, however if the build passes then I'm down to just merge as-is and then move to a unit test when doing the fix for the blocking call not returning

@ableegoldman
Copy link
Copy Markdown
Member

All test failures are unrelated, merging to trunk

@ableegoldman ableegoldman merged commit abb74d4 into apache:trunk Feb 26, 2022
@ableegoldman
Copy link
Copy Markdown
Member

Merged to trunk

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants