Skip to content

KAFKA-12648: standardize startup timeout to fix some flaky NamedTopologyIntegrationTest tests#11824

Merged
ableegoldman merged 5 commits intoapache:trunkfrom
ableegoldman:12648-fix-flaky-NamedTopologyIntegrationTest
Mar 1, 2022
Merged

KAFKA-12648: standardize startup timeout to fix some flaky NamedTopologyIntegrationTest tests#11824
ableegoldman merged 5 commits intoapache:trunkfrom
ableegoldman:12648-fix-flaky-NamedTopologyIntegrationTest

Conversation

@ableegoldman
Copy link
Copy Markdown
Member

Seen a few of the new tests added fail on PR builds lately with the classic

java.lang.AssertionError: Expected all streams instances in [org.apache.kafka.streams.processor.internals.namedtopology.KafkaStreamsNamedTopologyWrapper@7fb3e6b0] to be RUNNING within 30000 ms, but the following were not: {org.apache.kafka.streams.processor.internals.namedtopology.KafkaStreamsNamedTopologyWrapper@7fb3e6b0=ERROR}

Since Jenkins unfortunately truncates the logs before we even get to running this specific test (due to large kafka & Config logging, see #11823) so I can't say for sure that it's environmental vs an actual issue, but bumping up the timeout will help us rule this out if we continue to see failures. We already had some tests using the 30s timeout while others were bumped all the way up to 60s, I figured we should try out a default timeout of 45s and if we still see failures in specific tests we can go from there

Copy link
Copy Markdown
Contributor

@guozhangwang guozhangwang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ableegoldman
Copy link
Copy Markdown
Member Author

All test failures are unrelated, with no failures of the highly-flaky NamedTopologyIntegrationTests -- will merge

@ableegoldman ableegoldman merged commit 84f8c90 into apache:trunk Mar 1, 2022
@ableegoldman
Copy link
Copy Markdown
Member Author

Merged to trunk

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants