MINOR: fix flaky shouldRemoveOneNamedTopologyWhileAnotherContinuesProcessing#11827
Merged
ableegoldman merged 4 commits intoapache:trunkfrom Mar 4, 2022
Conversation
Member
Author
|
Call for review @guozhangwang @wcarlson5 |
guozhangwang
approved these changes
Mar 1, 2022
Contributor
guozhangwang
left a comment
guozhangwang
left a comment
There was a problem hiding this comment.
LGTM! And thanks for removing redundant topics creations too.
wcarlson5
approved these changes
Mar 1, 2022
…mpicitely created by one of the tests
Member
Author
|
Note that one additional fix is required to completely mend this: #11847 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This test has been failing somewhat regularly due to going into the ERROR state before reaching RUNNING during the startup phase. The problem is that we are reusing the
DELAYED_INPUT_STREAMtopics, which had previously been assumed to be uniquely owned by a particular test. We should make sure to delete and re-create these topics for any test that uses them.