Skip to content

KAFKA-13671: Add ppc64le build stage#11833

Merged
mimaison merged 2 commits intoapache:trunkfrom
mimaison:KAFKA-13671
Mar 7, 2022
Merged

KAFKA-13671: Add ppc64le build stage#11833
mimaison merged 2 commits intoapache:trunkfrom
mimaison:KAFKA-13671

Conversation

@mimaison
Copy link
Copy Markdown
Member

@mimaison mimaison commented Mar 2, 2022

Committer Checklist (excluded from commit message)

  • Verify design and implementation
  • Verify test coverage and CI build status
  • Verify documentation (including upgrade notes)

@mimaison
Copy link
Copy Markdown
Member Author

mimaison commented Mar 2, 2022

It looks like there's a permission issue with /tmp. I'm following up in KAFKA-13671.

@mimaison
Copy link
Copy Markdown
Member Author

mimaison commented Mar 2, 2022

We resolved the permissions issues and it's now working. I'll let this build finish and I'll kick another one tomorrow to confirm.

@mimaison mimaison requested a review from mumrah March 3, 2022 16:36
Copy link
Copy Markdown
Member

@mumrah mumrah left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @mimaison, this looks good to me. Can we make the stage name something like "PPC" or "PowerPC" just for readability?

Looking at our docs, all I could find about platform support is

Kafka should run well on any unix system and has been tested on Linux and Solaris.

I wonder if we should include some details about the platforms we test. I also wonder about that Solaris part -- has anyone actually tested a recent build on Solaris?

Anyways, this PR LGTM pending a passing build, thanks 👍

@mimaison
Copy link
Copy Markdown
Member Author

mimaison commented Mar 4, 2022

Thanks @mumrah! I've renamed the stage to PowerPC.
Regarding supported platforms, I'm not aware of anybody testing recent builds on Solaris. I'll follow up with a small docs PR to update that statement.

Test failures are unrelated, merging to trunk.

@mimaison mimaison merged commit bbb2dc5 into apache:trunk Mar 7, 2022
@mimaison mimaison deleted the KAFKA-13671 branch March 7, 2022 09:18
Comment thread Jenkinsfile
timestamps()
}
environment {
SCALA_VERSION=2.12
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Scala 2.12 support has been deprecated, it would be good to use Scala 2.13 for new stages.

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good point, I'll follow up with a few more changes we should do in this area.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants