KAFKA-13705: CoreUtils.swallow uses logging parameter instead of Logger

[Corlobin]

As described in the issue, the:

• Javadoc says: The logging instance to use for logging the thrown exception.

But logging parameter it is never used.

The testing strategy used was to run the CoreUtilsTest class and all test projects classes to check if any was broken.

Committer Checklist (excluded from commit message)

• Verify design and implementation
• Verify test coverage and CI build status
• Verify documentation (including upgrade notes)

[showuon]

@Corlobin , thanks for the PR. LGTM. But there are spotBug error, could you fix them? Thanks.

[Corlobin]

Hi Luke, thanks! I'm taking a look!

[Corlobin]

Hi @showuon, I believe that is a false-positive, running the spotbugsMain from trunk I receive 6 warnings as described below: spotbugs/spotbugs#1963

I reported a bug on spotbugs and commited the ignore file on spotbugs-exclude.xml.

I'm waiting a answer from spotbugs repo but I believe ithis s the same false-positive from others spotbugs described in the spotbugs-exclude file.

[showuon]

@Corlobin , thanks for the update. Exclude the SA_FIELD_SELF_COMPARISON looks good to me. But there are failed tests that don't fail in trunk build. Could you help check them?

Build / JDK 8 and Scala 2.12 / kafka.api.PlaintextProducerSendTest.testSendWithInvalidCreateTime()
Build / JDK 8 and Scala 2.12 / kafka.server.ProduceRequestTest.testProduceWithInvalidTimestamp()

ref: https://ci-builds.apache.org/job/Kafka/job/kafka-pr/job/PR-11841/4/#showFailuresLink

[showuon]

Thanks for the investigation. I agree it should be false positive. Could we add the spotbugs github issue link here to indicate this should be removed after issue fixed?

[Corlobin]

Thanks @showuon , great idea, github issue link added!

[Corlobin]

Thanks @showuon it seems these tests failed appeared on merge of another PR: #11830 after my investigation.

Excluded line: https://github.com/apache/kafka/pull/11830/files#r820125170 (as commented)

Link error with these tests: https://ci-builds.apache.org/blue/organizations/jenkins/Kafka%2Fkafka-pr/detail/PR-11830/3/tests

Existing failures - 10
Build / JDK 8 and Scala 2.12 / testSendWithInvalidCreateTime() – kafka.api.PlaintextProducerSendTest
3s
Build / JDK 8 and Scala 2.12 / testSendWithInvalidCreateTime() – kafka.api.PlaintextProducerSendTest
6s
Build / JDK 8 and Scala 2.12 / testProduceWithInvalidTimestamp() – kafka.server.ProduceRequestTest
2s
Build / JDK 8 and Scala 2.12 / testProduceWithInvalidTimestamp() – kafka.server.ProduceRequestTest
2s
Build / JDK 11 and Scala 2.13 / testSendWithInvalidCreateTime() – kafka.api.PlaintextProducerSendTest
2s
Build / JDK 11 and Scala 2.13 / testSendWithInvalidCreateTime() – kafka.api.PlaintextProducerSendTest
7s
Build / JDK 11 and Scala 2.13 / testProduceWithInvalidTimestamp() – kafka.server.ProduceRequestTest
3s
Build / JDK 11 and Scala 2.13 / testProduceWithInvalidTimestamp() – kafka.server.ProduceRequestTest
2s
Build / JDK 17 and Scala 2.13 / testSendWithInvalidCreateTime() – kafka.api.PlaintextProducerSendTest
3s
Build / JDK 17 and Scala 2.13 / testProduceWithInvalidTimestamp() – kafka.server.ProduceRequestTest
3s

Could you confirm please if was introduced by my PR or was failing before?

[showuon]

Yes, you're right! Those tests are introduced by other PR. However, the recent jenkins build doesn't complete successfully. I've triggered another one to check it.
https://ci-builds.apache.org/job/Kafka/job/kafka-pr/job/PR-11841/7/

[Corlobin]

Hi @showuon , thanks!!!

It seems the error is related to a failed gradle step not related to my commits.

As you can see build passes:

I Investigated and I do believe these errors are related to this line:

kafka/Jenkinsfile

Line 41 in 0118330

junit '**/build/test-results/**/TEST-*.xml'

I'll try to keep investigating.. maybe this is due to failed tests? (related to my previous comment)

[github-actions]

This PR is being marked as stale since it has not had any activity in 90 days. If you
would like to keep this PR alive, please leave a comment asking for a review. If the PR has
merge conflicts, update it with the latest from the base branch.

If you are having difficulty finding a reviewer, please reach out on the [mailing list](https://kafka.apache.org/contact).

If this PR is no longer valid or desired, please feel free to close it. If no activity occurs in the next 30 days, it will be automatically closed.

[github-actions]

This PR has been closed since it has not had any activity in 120 days. If you feel like this
was a mistake, or you would like to continue working on it, please feel free to re-open the
PR and ask for a review.