Skip to content

KAFKA-13689: Revert AbstractConfig code changes#11863

Merged
showuon merged 30 commits intoapache:trunkfrom
RivenSun2:KAFKA-13689-revert
Mar 10, 2022
Merged

KAFKA-13689: Revert AbstractConfig code changes#11863
showuon merged 30 commits intoapache:trunkfrom
RivenSun2:KAFKA-13689-revert

Conversation

@RivenSun2
Copy link
Copy Markdown
Contributor

Because the previous code involves the modification of the public module, a KIP needs to be provided;
At the same time, the consideration of some scenarios was ignored, so it was decided to revert the previous code changes

RivenSun2 and others added 30 commits September 19, 2021 17:59
… cpu and traffic on the broker side increase sharply

JIRA link : https://issues.apache.org/jira/browse/KAFKA-13310

Author: RivenSun2 <riven.sun@zoom.us>

Reviewers: Luke Chen <showuon@gmail.com>
…sets method

JIRA link : https://issues.apache.org/jira/browse/KAFKA-13310

Author: RivenSun2 <riven.sun@zoom.us>

Reviewers: Luke Chen <showuon@gmail.com>
2. Optimize the import of package

Author: RivenSun2 <riven.sun@zoom.us>

Reviewers: Luke Chen <showuon@gmail.com>
Author: RivenSun2 <riven.sun@zoom.us>

Reviewers: Luke Chen <showuon@gmail.com>
Author: RivenSun2 <riven.sun@zoom.us>

Reviewers: Luke Chen <showuon@gmail.com>
Author: RivenSun2 <riven.sun@zoom.us>

Reviewers: Luke Chen <showuon@gmail.com>
Author: RivenSun2 <riven.sun@zoom.us>

Reviewers: Luke Chen <showuon@gmail.com>
add test Method "testForceMetadataDeleteForPatternSubscriptionDuringRebalance()"

Author: RivenSun2 <riven.sun@zoom.us>

Reviewers: Luke Chen <showuon@gmail.com>
Author: RivenSun2 <riven.sun@zoom.us>

Reviewers: Luke Chen <showuon@gmail.com>
Author: RivenSun2 riven.sun@zoom.us
� Conflicts:
�	clients/src/test/java/org/apache/kafka/clients/consumer/KafkaConsumerTest.java
@RivenSun2
Copy link
Copy Markdown
Contributor Author

Hi @showuon
Please help to review the PR .
Thanks.

@RivenSun2 RivenSun2 changed the title KAFKA-13689: Revert code changes KAFKA-13689: Revert AbstractConfig code changes Mar 8, 2022
@showuon
Copy link
Copy Markdown
Member

showuon commented Mar 8, 2022

Note: reverting #11800.

Copy link
Copy Markdown
Member

@showuon showuon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@showuon showuon merged commit 84b41b9 into apache:trunk Mar 10, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants