KAFKA-13750: Client Compatability KafkaTest uses invalid idempotency configs#11909
Merged
dajac merged 2 commits intoapache:trunkfrom Mar 17, 2022
Merged
KAFKA-13750: Client Compatability KafkaTest uses invalid idempotency configs#11909dajac merged 2 commits intoapache:trunkfrom
dajac merged 2 commits intoapache:trunkfrom
Conversation
showuon
reviewed
Mar 17, 2022
Comment on lines
+178
to
+183
| .action(store()) | ||
| .required(true) | ||
| .type(Boolean.class) | ||
| .dest("idempotentProducerSupported") | ||
| .metavar("IDEMPOTENT_PRODUCER_SUPPORTED") | ||
| .help("Whether the producer supports idempotency."); |
Member
There was a problem hiding this comment.
indent is not aligned with above lines.
Member
|
@jolshan Would you have a link to a successful run of the tests with your change? |
Member
Author
Member
|
@jolshan Thanks. Do we need to backport it to older branches? I guess that we need it in 3.1 and 3.0, right? |
Member
|
We don't need to wait for the build as this is a python change. Merging to trunk, 3.1 and 3.0. |
dajac
pushed a commit
that referenced
this pull request
Mar 17, 2022
… configs (#11909) Reviewers: Luke Chen <showuon@gmail.com>, David Jacot <djacot@confluent.io>
dajac
pushed a commit
that referenced
this pull request
Mar 17, 2022
… configs (#11909) Reviewers: Luke Chen <showuon@gmail.com>, David Jacot <djacot@confluent.io>
jeffkbkim
pushed a commit
to confluentinc/kafka
that referenced
this pull request
May 12, 2022
… configs (apache#11909) Reviewers: Luke Chen <showuon@gmail.com>, David Jacot <djacot@confluent.io>
jeffkbkim
added a commit
to confluentinc/kafka
that referenced
this pull request
May 12, 2022
…cs-12-may-2022 * apache-kafka/3.0: (14 commits) fix: make sliding window works without grace period (#kafka-13739) (apache#11980) KAFKA-13794: Follow up to fix producer batch comparator (apache#12006) KAFKA-13794; Fix comparator of `inflightBatchesBySequence` in `TransactionManager` (apache#11991) KAFKA-13748: Do not include file stream connectors in Connect's CLASSPATH and plugin.path by default (apache#11908) KAFKA-13418: Support key updates with TLS 1.3 (apache#11966) KAFKA-13770: Restore compatibility with KafkaBasedLog using older Kafka brokers (apache#11946) KAFKA-13761: KafkaLog4jAppender deadlocks when idempotence is enabled (apache#11939) KAFKA-13759: Disable idempotence by default in producers instantiated by Connect (apache#11933) MINOR: Fix `ConsumerConfig.ISOLATION_LEVEL_DOC` (apache#11915) KAFKA-13750; Client Compatability KafkaTest uses invalid idempotency configs (apache#11909) ...
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
With the switch to idempotency as a default, ClientCompatibilityFeaturesTest.run_compatibility_test broke for versions prior to 0.11 where EOS was enabled. This PR disables idempotency for kafka versions prior to 0.11.
Committer Checklist (excluded from commit message)