Skip to content

[MINOR] fix(streams): align variable names #11999

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
vvcephei merged 1 commit into from
Apr 11, 2022
Merged

[MINOR] fix(streams): align variable names #11999

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions streams/src/main/java/org/apache/kafka/streams/state/ReadOnlySessionStore.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -322,9 +322,9 @@ default KeyValueIterator<Windowed<K>, AGG> backwardFindSessions(final K keyFrom,
/**
* Get the value of key from a single session.
*
* @param key the key to fetch
* @param key the key to fetch
* @param sessionStartTime start timestamp of the session
* @param sessionEndTime end timestamp of the session
* @param sessionEndTime end timestamp of the session
* @return The value or {@code null} if no session with the exact start and end timestamp exists
* for the given key
* @throws NullPointerException If {@code null} is used for any key.
Expand All @@ -339,9 +339,9 @@ default AGG fetchSession(final K key,
/**
* Get the value of key from a single session.
*
* @param key the key to fetch
* @param key the key to fetch
* @param sessionStartTime start timestamp of the session
* @param sessionEndTime end timestamp of the session
* @param sessionEndTime end timestamp of the session
* @return The value or {@code null} if no session with the exact start and end timestamp exists
* for the given key
* @throws NullPointerException If {@code null} is used for any key.
Expand Down
12 changes: 7 additions & 5 deletions streams/src/main/java/org/apache/kafka/streams/state/SessionStore.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -89,12 +89,14 @@ default KeyValueIterator<Windowed<K>, AGG> backwardFindSessions(final K keyFrom,
prepareMillisCheckFailMsgPrefix(latestSessionStartTime, "latestSessionStartTime")));
}

default AGG fetchSession(final K key, final Instant earliestSessionEndTime, final Instant latestSessionStartTime) {
default AGG fetchSession(final K key,
final Instant sessionStartTime,
final Instant sessionEndTime) {
return fetchSession(key,
ApiUtils.validateMillisecondInstant(earliestSessionEndTime,
prepareMillisCheckFailMsgPrefix(earliestSessionEndTime, "startTime")),
ApiUtils.validateMillisecondInstant(latestSessionStartTime,
prepareMillisCheckFailMsgPrefix(latestSessionStartTime, "endTime")));
ApiUtils.validateMillisecondInstant(sessionStartTime,
prepareMillisCheckFailMsgPrefix(sessionStartTime, "sessionStartTime")),
ApiUtils.validateMillisecondInstant(sessionEndTime,
prepareMillisCheckFailMsgPrefix(sessionEndTime, "sessionEndTime")));
}

/**
Expand Down