MINOR: Rename AlterIsrManager to AlterPartitionManager#12089
Merged
hachikuji merged 5 commits intoapache:trunkfrom Apr 26, 2022
Merged
MINOR: Rename AlterIsrManager to AlterPartitionManager#12089hachikuji merged 5 commits intoapache:trunkfrom
AlterIsrManager to AlterPartitionManager#12089hachikuji merged 5 commits intoapache:trunkfrom
Conversation
dengziming
reviewed
Apr 23, 2022
Member
dengziming
left a comment
dengziming
left a comment
There was a problem hiding this comment.
Thank you for this PR @hachikuji , left one question.
dajac
reviewed
Apr 23, 2022
Member
dajac
left a comment
dajac
left a comment
There was a problem hiding this comment.
Renaming it makes sense. Left a small nit.
Contributor
Author
|
@dajac @dengziming Thanks for reviews. Pushed an update. |
dengziming
approved these changes
Apr 24, 2022
Member
dengziming
left a comment
dengziming
left a comment
There was a problem hiding this comment.
LGTM, there are still 1 minor improvements: ApiKeysTest.testAlterIsrIsClusterAction.
dengziming
approved these changes
Apr 25, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Since we have changed the
AlterIsrAPI toAlterPartition, it makes sense to renameAlterIsrManageras well.Committer Checklist (excluded from commit message)