Skip to content

MINOR: Small cleanups in connect/mirror#12113

Merged
showuon merged 1 commit intoapache:trunkfrom
mimaison:mirror-cleanups
May 10, 2022
Merged

MINOR: Small cleanups in connect/mirror#12113
showuon merged 1 commit intoapache:trunkfrom
mimaison:mirror-cleanups

Conversation

@mimaison
Copy link
Copy Markdown
Member

@mimaison mimaison commented May 2, 2022

  • Make a few fields final
  • Remove unnecessary throws

Committer Checklist (excluded from commit message)

  • Verify design and implementation
  • Verify test coverage and CI build status
  • Verify documentation (including upgrade notes)

@divijvaidya
Copy link
Copy Markdown
Member

Hey @mimaison, one of the flaky tests failing for this PR is testListenerConnectionRateLimitWhenActualRateAboveLimit() – kafka.network.ConnectionQuotasTest which I have fixed as part of #12045

If you get a chance, please review my PR and that will reduce some degree of flakiness from the existing test suite.

Thanks in advance!

Copy link
Copy Markdown
Member

@showuon showuon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks for the PR.

@showuon
Copy link
Copy Markdown
Member

showuon commented May 10, 2022

Failed tests are unrelated:

Build / JDK 17 and Scala 2.13 / org.apache.kafka.streams.integration.NamedTopologyIntegrationTest.shouldAddToEmptyInitialTopologyRemoveResetOffsetsThenAddSameNamedTopology
Build / JDK 8 and Scala 2.12 / kafka.server.KRaftClusterTest.testCreateClusterAndPerformReassignment()
Build / JDK 11 and Scala 2.13 / kafka.network.ConnectionQuotasTest.testListenerConnectionRateLimitWhenActualRateAboveLimit()

@showuon showuon merged commit 989d3ce into apache:trunk May 10, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants