Merged
Conversation
Gerrrr
force-pushed
the
KAFKA-13769-upgrade-tests
branch
3 times, most recently
from
5a6dea4 to
d25cdd4
Compare
Gerrrr
force-pushed
the
KAFKA-13769-upgrade-tests
branch
from
3a69e4c to
371c5b9
Compare
Contributor
Author
|
@mjsax Can you please review? |
mjsax
reviewed
May 10, 2022
Member
mjsax
left a comment
mjsax
left a comment
There was a problem hiding this comment.
Thanks for the PR. Can you trigger a system test run to ensure it's working before we merge it.
|
|
||
| private static <KIn, VIn, KOut, VOut> ProcessorSupplier<KIn, VIn, KOut, VOut> printProcessorSupplier() { | ||
| private static void buildFKTable(final KStream<String, Integer> primaryTable, | ||
| final KTable<Integer, String> otherTable) { |
|
|
||
| metadata_1_versions = [str(LATEST_0_10_0)] | ||
| metadata_2_versions = [str(LATEST_0_10_1), str(LATEST_0_10_2), str(LATEST_0_11_0), str(LATEST_1_0), str(LATEST_1_1)] | ||
| fk_join_versions = [str(V_2_4_0)] |
Member
There was a problem hiding this comment.
We only test with latest bug-fix releases, so we can use LATEST_2_4 here.
Member
There was a problem hiding this comment.
Should we test all versions 2.4 - 3.1 ?
Contributor
Author
|
@mjsax How can I trigger system tests in the CI? |
Gerrrr
force-pushed
the
KAFKA-13769-upgrade-tests
branch
from
d530a29 to
4ea47f1
Compare
Contributor
Author
|
Green CI run with system tests - https://jenkins.confluent.io/job/system-test-kafka-branch-builder/4897/. |
Gerrrr
changed the title
3 tasks
3 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds upgrade tests for the changes in Foreign Key join protocol in KAFKA-13769. New upgrade tests ensure that FK joins keep working after a 2-bounce upgrade despite the protocol changes. I added the tests for all Kafka versions starting from 2.4 - the version that introduced FK joins.
Committer Checklist (excluded from commit message)