Skip to content

MINOR: Clarify impact of num.replica.fetchers#12153

Merged
hachikuji merged 2 commits intoapache:trunkfrom
joel-hamill:joel-hamill/DOCS-13761
May 16, 2022
Merged

MINOR: Clarify impact of num.replica.fetchers#12153
hachikuji merged 2 commits intoapache:trunkfrom
joel-hamill:joel-hamill/DOCS-13761

Conversation

@joel-hamill
Copy link
Copy Markdown
Contributor

More detailed description of your change,
if necessary. The PR title and PR message become
the squashed commit message, so use a separate
comment to ping reviewers.

Summary of testing strategy (including rationale)
for the feature or bug fix. Unit and/or integration
tests are expected for any behaviour change and
system tests should be considered for larger changes.

Committer Checklist (excluded from commit message)

  • Verify design and implementation
  • Verify test coverage and CI build status
  • Verify documentation (including upgrade notes)

@joel-hamill
Copy link
Copy Markdown
Contributor Author

cc @guozhangwang @hachikuji

Comment thread core/src/main/scala/kafka/server/KafkaConfig.scala Outdated
Comment thread core/src/main/scala/kafka/server/KafkaConfig.scala Outdated
Comment thread core/src/main/scala/kafka/server/KafkaConfig.scala Outdated
@divijvaidya
Copy link
Copy Markdown
Member

@hachikuji one of the flaky failing tests in this PR is Build / JDK 11 and Scala 2.13 / testListenerConnectionRateLimitWhenActualRateAboveLimit() – kafka.network.ConnectionQuotasTest I have fixed that test at #12045

Please take a look when you get a chance.

@joel-hamill joel-hamill force-pushed the joel-hamill/DOCS-13761 branch from 0957f08 to df873e1 Compare May 13, 2022 13:58
Copy link
Copy Markdown
Contributor

@hachikuji hachikuji left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, LGTM.

@hachikuji hachikuji merged commit 0605198 into apache:trunk May 16, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants