Skip to content

Kafka 13888 new fields#12212

Closed
lqjack wants to merge 3 commits intoapache:trunkfrom
lqjack:KAFKA-13888-new-fields
Closed

Kafka 13888 new fields#12212
lqjack wants to merge 3 commits intoapache:trunkfrom
lqjack:KAFKA-13888-new-fields

Conversation

@lqjack
Copy link
Copy Markdown
Contributor

@lqjack lqjack commented May 25, 2022

  • create file if not exist
    update lastCaughtUpTimestamp
    update lastFetchTimestamp
    Summary of testing strategy (including rationale)
    for the feature or bug fix. Unit and/or integration
    tests are expected for any behaviour change and
    system tests should be considered for larger changes.

Committer Checklist (excluded from commit message)

  • Verify design and implementation
  • Verify test coverage and CI build status
  • Verify documentation (including upgrade notes)

niket-goel and others added 3 commits May 24, 2022 14:39
…Voter Lag

This commit adds an Admin API handler for DescribeQuorum Request and also
adds in two new fields LastFetchTimestamp and LastCaughtUpTimestamp to
the DescribeQuorumResponse as described by KIP-836.

This commit does not implement the newly added fields. Those will be
added in a subsequent commit.
Changes:
Added some unit tests to KafkaAdminClientTest
Merged multiple DescribeQuorumTest files
Some other refactoring
@hachikuji
Copy link
Copy Markdown
Contributor

@lqjack Can you merge with trunk please?

@niket-goel
Copy link
Copy Markdown
Contributor

Hey @lqjack . Thanks for raising this PR. The PR #12206 has now been merged to trunk. Can you please update your PR with the latest code so we can iterate on it?

@jsancio jsancio added core Kafka Broker 3.3 labels Aug 5, 2022
@ijuma
Copy link
Copy Markdown
Member

ijuma commented Aug 10, 2022

@lqjack Are you still planning to work on this? If we don't hear from you in the next couple of days, then someone else may pick it up and drive it forward.

@niket-goel
Copy link
Copy Markdown
Contributor

The following PR #12508 implements this functionality. This PR can be closed.

@jsancio
Copy link
Copy Markdown
Member

jsancio commented Aug 31, 2022

@lqjack I am closing the PR. It looks like this issue was fixed by #12206 and #12508

@jsancio jsancio closed this Aug 31, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

core Kafka Broker

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants