MINOR: Update the kafka-reassign-partitions script command in documentation#12237
MINOR: Update the kafka-reassign-partitions script command in documentation#12237showuon merged 2 commits intoapache:trunkfrom
Conversation
showuon
left a comment
showuon
left a comment
There was a problem hiding this comment.
@RivenSun2 , thanks for the PR. Yes, this is a bug that I've already addressed in another PR. (but got no response :)). So, let's fix it here! In my PR, I also found the command output is different now. I saw you fix some (add "inter-broker"), but from my previous observation (3 months ago), there are still some other places needed to be updated. Could you help confirm them?
Thank you.
|
@showuon ok i will compare carefully and revise to latest correct output. |
| if (state.done) { | ||
| if (state.currentReplicas.equals(state.targetReplicas)) { | ||
| bld.append("Reassignment of partition %s is complete.". | ||
| bld.append("Reassignment of partition %s is completed.". |
There was a problem hiding this comment.
Adjust the output here.
| Successfully started reassignment of partitions | ||
| {"version":1, | ||
| "partitions":[{"topic":"foo","partition":0,"replicas":[5,6,7]}]}</code></pre> | ||
| Successfully started partition reassignment for foo-0</code></pre> |
There was a problem hiding this comment.
Because there is only one topicPartition, output reassignment instead of reassignments
| Reassignment of partition [my-topic,1] is completed | ||
| Reassignment of partition [my-topic,0] is completed | ||
|
|
||
| Clearing broker-level throttles on brokers 1,2,3 | ||
| Clearing topic-level throttles on topic my-topic</code></pre> |
There was a problem hiding this comment.
According to the actual output result, there will be a blank line in the middle
|
Hi @showuon |
showuon
left a comment
showuon
left a comment
There was a problem hiding this comment.
LGTM! I'm going to close my PR then. Thank you.
|
Waiting for the jenkins build since we have a output change in |
|
The failed testcase: |
|
The same error also appeared in a merged PR a few days ago: and another PR that doesn't contain changes from this PR: |
showuon
changed the title
|
@RivenSun2 , could you also file a PR to kafka-site repo to fix the current doc? Thanks. |
|
Hi @showuon my pleasure. But I don't know how I need to do it? |
What we fixed will not be reflected to the doc link until next release. To fix the issue in the current doc link: (ex: here), we should fix in the |
|
Ok thanks for the suggestion, I'll create a PR in that project later. |
2 participants
As mentioned in Notable changes in 2.6.0 : There are several notable changes to the reassignment tool kafka-reassign-partitions.sh following the completion of KIP-455. This tool now requires the --additional flag to be provided when changing the throttle of an active reassignment.
It is recommended that the actual operation guidance document should also be updated to avoid causing confusion to users. Otherwise, following the original documentation, the user will see an exception:
Cannot execute because there is an existing partition assignment. Use --additional to override this and create a new partition assignment in addition to the existing one. The --additional flag can also be used to change the throttle by resubmitting the current reassignment.Committer Checklist (excluded from commit message)