KAFKA-13990: KRaft controller should return right features in ApiVersionResponse#12294
Merged
cmccabe merged 1 commit intoapache:trunkfrom Aug 31, 2022
Merged
KAFKA-13990: KRaft controller should return right features in ApiVersionResponse#12294cmccabe merged 1 commit intoapache:trunkfrom
cmccabe merged 1 commit intoapache:trunkfrom
Conversation
Member
Author
dengziming
force-pushed
the
KAFKA-13990
branch
from
921fff3 to
828a2a7
Compare
Member
Author
|
This is an issue of big influence since it will prevent us from upgrading KRaft cluster, also ping @hachikuji @mumrah |
dengziming
force-pushed
the
KAFKA-13990
branch
from
828a2a7 to
d87a53a
Compare
dengziming
commented
Aug 30, 2022
Member
Author
There was a problem hiding this comment.
This test case will fail without this change, can you take a look at this PR @jsancio , I wish this can be merged into 3.3.
Member
dengziming
force-pushed
the
KAFKA-13990
branch
from
d87a53a to
99b1bfd
Compare
Contributor
|
Thanks for finding this, @dengziming . It is a great find and definitely a 3.3 blocker. |
Contributor
|
So, the reason we didn't notice this bug earlier is that it doesn't affect single-node clusters. And in the multi-node ducktape test that I wrote, the upgrade command was failing but we didn't notice because the error code returned was 0 (success). I will open a PR to fix the kafka-features.sh return code. |
cmccabe
pushed a commit
that referenced
this pull request
Aug 31, 2022
…ionResponse (#12294) Previously, the KRaft controller was incorrectly reporting an empty feature set in ApiVersionResponse. This was preventing any multi-node clusters from being upgraded via kafka-features.sh, since they would incorrectly believe that metadata.version was not a supported feature. This PR adds a regression test for this bug, KRaftClusterTest.testUpdateMetadataVersion. Reviewers: José Armando García Sancio <jsancio@gmail.com>, Colin P. McCabe <cmccabe@apache.org>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
More detailed description of your change
Updating metadata.version using AdminClient will fail with the following exception:
This is because we just return empty supported features in Controller ApiVersionResponse, so
QuorumFeatures.reasonNotSupportedwill always assume we don't support this version.Summary of testing strategy (including rationale)
KRaftClusterTest.testUpdateMetadataVersion
Committer Checklist (excluded from commit message)