KAFKA-3406; Update CommonClientConfigs.RETRY_BACKOFF_MS_DOC doc string#1230
Closed
omkreddy wants to merge 1 commit into
Closed
KAFKA-3406; Update CommonClientConfigs.RETRY_BACKOFF_MS_DOC doc string#1230omkreddy wants to merge 1 commit into
omkreddy wants to merge 1 commit into
Conversation
|
+1 |
Contributor
Author
|
@ijuma pinging for review and commit |
Member
There was a problem hiding this comment.
I think I would say the second sentence as:
"This avoids repeatedly sending requests in a tight loop under some failure scenarios."
As it's phrased, it could be interpreted as meaning that we would repeatedly fail the same request.
Contributor
Author
There was a problem hiding this comment.
Agreed. Updated the patch.
Member
|
LGTM |
gfodor
pushed a commit
to AltspaceVR/kafka
that referenced
this pull request
Jun 3, 2016
Author: Manikumar reddy O <manikumar.reddy@gmail.com> Reviewers: Sriharsha Chintalapani <schintalapani@hortonworks.com>, Ismael Juma <ismael@juma.me.uk> Closes apache#1230 from omkreddy/KAFKA-3406
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.