KAFKA-3580; improve error logging in ReplicaFetchThread#1237
Closed
omkreddy wants to merge 1 commit into
Closed
Conversation
Contributor
Author
|
@ijuma pinging for review |
Member
There was a problem hiding this comment.
We should use string interpolation instead of string concatenation here.
Member
There was a problem hiding this comment.
I think I'd keep it as one sentence. Also, we need an empty space at the end of the line.
Member
|
LGTM |
gfodor
pushed a commit
to AltspaceVR/kafka
that referenced
this pull request
Jun 3, 2016
Author: Manikumar reddy O <manikumar.reddy@gmail.com> Reviewers: Ismael Juma <ismael@juma.me.uk> Closes apache#1237 from omkreddy/KAFKA-3580
efeg
added a commit
to efeg/kafka
that referenced
this pull request
May 29, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.