MINOR: add unit test for KGroupedTable.count#1255
Conversation
| import static org.junit.Assert.assertThat; | ||
|
|
||
|
|
||
| public class KGroupedTableCountTest { |
There was a problem hiding this comment.
Could you rename this class file to KGroupedTableImplTest?
|
Checkstyle failure: Do we have to introduce this dependency? In general we want to have as less external dependencies as possible. |
|
|
@dguy: Some background information regarding your earlier comment: The Kafka project has been pretty sensitive to introducing new dependencies, including test-scope dependencies. That said, I'm on your side. :-) This question is perhaps something we should discuss with other Kafka folks, because -- intentionally over-simplified -- I'd prefer us not to be stuck with |
|
@guozhangwang : Can you take a look again? It'd be great to include this test improvement before the 0.10 release. |
| import static org.junit.Assert.assertEquals; | ||
|
|
||
|
|
||
| public class KGroupedTableImplCountTest { |
There was a problem hiding this comment.
nit: we can rename it to KGroupedTableImplTest and add more test cases into this class in the future.
Author: Damian Guy <damian.guy@gmail.com> Reviewers: Guozhang Wang <wangguoz@gmail.com>, Michael G. Noll <michael@confluent.io> Closes apache#1255 from dguy/kgroupedtable-count-test
* Find coordinator RPC impl for share group CRUD RPCs. * Added PersisterStateManager to handle RPCs. * Added PersisterConfig class to supply config for Persister. * Updated Persister interface to add `stop` and `configure` methods. * Updated broker server which now instantiates and manages the persister instance creation and pass it to appropriate classes. Major update: __share_group_state topic is getting created if not exisiting
3 participants
No description provided.