MINOR; Explain how to set old default partitioner#12630
Merged
ijuma merged 3 commits intoapache:trunkfrom Sep 13, 2022
Merged
Conversation
dajac
reviewed
Sep 13, 2022
| </li> | ||
| </ol> | ||
|
|
||
| <p>Note that upgrading client to 3.3.0 would introduce a new Sticky Partitioner, described in |
Member
There was a problem hiding this comment.
nit: We usually includes these kind of info in the Notable changes in 3.3.0 section. I would put it second in that list.
Member
There was a problem hiding this comment.
In addition to that, I would write something like:
The partitioner used by default for records with no keys has been improved to avoid pathological behavior when one or more brokers are slow. The new logic can affect the batching behavior, which can be tuned via batch.size and/or linger.ms. The previous behavior can be restored by setting partitioner.class=org.apache.kafka.clients.producer.internals.DefaultPartitioner. See KIP-794 for more details.
The above is just an idea, but the point is to include a short description of how it's better, highlight the potential need for additional tuning, explain how to restore the previous behavior and include a link to the KIP. I also skipped all formatting, but it's good that links, code, etc. were used.
jsancio
changed the title
Address review comments.
artemlivshits
commented
Sep 13, 2022
| </li> | ||
| </ol> | ||
|
|
||
| <p>Note that upgrading client to 3.3.0 would introduce a new Sticky Partitioner, described in |
ijuma
pushed a commit
that referenced
this pull request
Sep 13, 2022
…oner (KIP-794) (#12630) Reviewers: Ismael Juma <ismael@juma.me.uk>, David Jacot <djacot@confluent.io>
ijuma
added a commit
to confluentinc/kafka
that referenced
this pull request
Sep 21, 2022
…eptember 2022) `Jenkinsfile` was the only conflict and we ignore the changes since they are not relevant to the Confluent build. * apache-github/3.3: (61 commits) KAFKA-14214: Introduce read-write lock to StandardAuthorizer for consistent ACL reads. (apache#12628) KAFKA-14243: Temporarily disable unsafe downgrade (apache#12664) KAFKA-14240; Validate kraft snapshot state on startup (apache#12653) KAFKA-14233: disable testReloadUpdatedFilesWithoutConfigChange first to fix the build (apache#12658) KAFKA-14238; KRaft metadata log should not delete segment past the latest snapshot (apache#12655) KAFKA-14156: Built-in partitioner may create suboptimal batches (apache#12570) MINOR: Adds KRaft versions of most streams system tests (apache#12458) MINOR; Add missing li end tag (apache#12640) MINOR: Mention that kraft is production ready in upgrade notes (apache#12635) MINOR: Add upgrade note regarding the Strictly Uniform Sticky Partitioner (KIP-794) (apache#12630) KAFKA-14222; KRaft's memory pool should always allocate a buffer (apache#12625) KAFKA-14208; Do not raise wakeup in consumer during asynchronous offset commits (apache#12626) KAFKA-14196; Do not continue fetching partitions awaiting auto-commit prior to revocation (apache#12603) KAFKA-14215; Ensure forwarded requests are applied to broker request quota (apache#12624) MINOR; Remove end html tag from upgrade (apache#12605) Remove the html end tag from upgrade.html KAFKA-14205; Document how to replace the disk for the KRaft Controller (apache#12597) KAFKA-14203 Disable snapshot generation on broker after metadata errors (apache#12596) KAFKA-14216: Remove ZK reference from org.apache.kafka.server.quota.ClientQuotaCallback javadoc (apache#12617) KAFKA-14217: app-reset-tool.html should not show --zookeeper flag that no longer exists (apache#12618) ...
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Added a paragraph explaining how to set old default partitioner.
Committer Checklist (excluded from commit message)