KAFKA-14283; Fix connector creation Auth tests not correctly testing#12721
Merged
C0urante merged 1 commit intoapache:trunkfrom Oct 7, 2022
Merged
Conversation
Currently the testCreateConnectorWithoutHeaderAuthorization and testCreateConnectorWithHeaderAuthorization tests within ConnectorsResourceTest aren't actually anything. This is because in reality the requests should be forwarded to a leader and tests aren't actually testing that a leader RestClient request is made.
Contributor
Author
vamossagar12
reviewed
Oct 7, 2022
Contributor
vamossagar12
left a comment
vamossagar12
left a comment
There was a problem hiding this comment.
@mdedetrich , Thanks for the changes. It looks fine to me.
C0urante
approved these changes
Oct 7, 2022
Contributor
C0urante
left a comment
C0urante
left a comment
There was a problem hiding this comment.
LGTM, thanks for fixing this 👍
mdedetrich
deleted the
fix-test-create-connector-auth-not-doing-anything
branch
guozhangwang
pushed a commit
to guozhangwang/kafka
that referenced
this pull request
Jan 25, 2023
Reviewers: Sagar Rao <sagarmeansocean@gmail.com>, Chris Egerton <chrise@aiven.io>
rutvijmehta-harness
pushed a commit
to rutvijmehta-harness/kafka
that referenced
this pull request
Feb 9, 2024
Reviewers: Sagar Rao <sagarmeansocean@gmail.com>, Chris Egerton <chrise@aiven.io>
rutvijmehta-harness
added a commit
to rutvijmehta-harness/kafka
that referenced
this pull request
Feb 9, 2024
Reviewers: Sagar Rao <sagarmeansocean@gmail.com>, Chris Egerton <chrise@aiven.io> Co-authored-by: Matthew de Detrich <matthew.dedetrich@aiven.io>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Currently the testCreateConnectorWithoutHeaderAuthorization and testCreateConnectorWithHeaderAuthorization tests within ConnectorsResourceTest aren't actually anything. This is because in reality the requests should be forwarded to a leader and tests aren't actually testing that a leader RestClient request is made.