Skip to content

MINOR: Fix usage instruction of skipSigning build parameter#12731

Merged
bbejeck merged 1 commit intoapache:trunkfrom
lucasbru:fix_readme
Oct 24, 2022
Merged

MINOR: Fix usage instruction of skipSigning build parameter#12731
bbejeck merged 1 commit intoapache:trunkfrom
lucasbru:fix_readme

Conversation

@lucasbru
Copy link
Copy Markdown
Member

skipSigning parameter must be set to a boolean value to work.

Committer Checklist (excluded from commit message)

  • Verify design and implementation
  • Verify test coverage and CI build status
  • Verify documentation (including upgrade notes)

skipSigning parameter must be set to a boolean value to work.
@lucasbru
Copy link
Copy Markdown
Member Author

Test failures are unrelated

@bbejeck
Copy link
Copy Markdown
Member

bbejeck commented Oct 24, 2022

Failures unrelated - changes made in the README file

Copy link
Copy Markdown
Member

@bbejeck bbejeck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the fix @lucasbru, LGTM

@bbejeck bbejeck merged commit 7dcaec4 into apache:trunk Oct 24, 2022
@bbejeck
Copy link
Copy Markdown
Member

bbejeck commented Oct 24, 2022

merged #12731 into trunk

guozhangwang pushed a commit to guozhangwang/kafka that referenced this pull request Jan 25, 2023
…2731)

skipSigning parameter must be set to a boolean value to work.

Reviewers: Bill Bejeck <bbejeck@apache.org>
rutvijmehta-harness pushed a commit to rutvijmehta-harness/kafka that referenced this pull request Feb 9, 2024
…2731)

skipSigning parameter must be set to a boolean value to work.

Reviewers: Bill Bejeck <bbejeck@apache.org>
rutvijmehta-harness added a commit to rutvijmehta-harness/kafka that referenced this pull request Feb 9, 2024
…2731) (#81)

skipSigning parameter must be set to a boolean value to work.

Reviewers: Bill Bejeck <bbejeck@apache.org>

Co-authored-by: Lucas Brutschy <lucasbru@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants