Skip to content

MINOR: Fix incorrect example in feature command help#12732

Merged
hachikuji merged 1 commit intoapache:trunkfrom
hachikuji:minor-fix-misleading-help-in-feature-command
Oct 12, 2022
Merged

MINOR: Fix incorrect example in feature command help#12732
hachikuji merged 1 commit intoapache:trunkfrom
hachikuji:minor-fix-misleading-help-in-feature-command

Conversation

@hachikuji
Copy link
Copy Markdown
Contributor

@hachikuji hachikuji commented Oct 12, 2022

When using kafka-features.sh with the --feature parameter, we expect a numeric feature level (e.g. metadata.version=5). The help example suggests that we can also use a descriptive version string for metadata.version such as 3.3-IV3, which doesn't work.

Committer Checklist (excluded from commit message)

  • Verify design and implementation
  • Verify test coverage and CI build status
  • Verify documentation (including upgrade notes)

Copy link
Copy Markdown
Member

@dajac dajac left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@hachikuji hachikuji merged commit 4b30ed8 into apache:trunk Oct 12, 2022
cmccabe pushed a commit that referenced this pull request Oct 24, 2022
When using `kafka-features.sh` with the `--feature` parameter, we expect a numeric feature level (e.g. `metadata.version=5`). The help example suggests that we can also use a descriptive version string for `metadata.version` such as `3.3-IV3`, which doesn't work.

Reviewers: David Jacot <djacot@confluent.io>
guozhangwang pushed a commit to guozhangwang/kafka that referenced this pull request Jan 25, 2023
When using `kafka-features.sh` with the `--feature` parameter, we expect a numeric feature level (e.g. `metadata.version=5`). The help example suggests that we can also use a descriptive version string for `metadata.version` such as `3.3-IV3`, which doesn't work.

Reviewers: David Jacot <djacot@confluent.io>
rutvijmehta-harness pushed a commit to rutvijmehta-harness/kafka that referenced this pull request Feb 9, 2024
When using `kafka-features.sh` with the `--feature` parameter, we expect a numeric feature level (e.g. `metadata.version=5`). The help example suggests that we can also use a descriptive version string for `metadata.version` such as `3.3-IV3`, which doesn't work.

Reviewers: David Jacot <djacot@confluent.io>
rutvijmehta-harness added a commit to rutvijmehta-harness/kafka that referenced this pull request Feb 9, 2024
)

When using `kafka-features.sh` with the `--feature` parameter, we expect a numeric feature level (e.g. `metadata.version=5`). The help example suggests that we can also use a descriptive version string for `metadata.version` such as `3.3-IV3`, which doesn't work.

Reviewers: David Jacot <djacot@confluent.io>

Co-authored-by: Jason Gustafson <jason@confluent.io>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants