KAFKA-3621: Add tests for ApiVersionRequest/Response#1275
Closed
SinghAsDev wants to merge 5 commits into
Closed
Conversation
Contributor
Author
| // Override properties by mutating the passed Properties object | ||
| def propertyOverrides(properties: Properties): Unit | ||
| // If required, set number of brokers | ||
| protected def numBrokers(): Int = 3 |
Contributor
Author
There was a problem hiding this comment.
Ahh.. one of these days I will stop doing this :).
Contributor
Author
|
@ijuma took care of the changes suggested. Mind giving it another pass? |
Member
|
LGTM |
gfodor
pushed a commit
to AltspaceVR/kafka
that referenced
this pull request
Jun 3, 2016
Author: Ashish Singh <asingh@cloudera.com> Reviewers: Ismael Juma <ismael@juma.me.uk> Closes apache#1275 from SinghAsDev/KAFKA-3621
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.