KAFKA-14299: Never transition to UpdateStandby twice#12762
Merged
cadonna merged 4 commits intoapache:trunkfrom Oct 19, 2022
Merged
KAFKA-14299: Never transition to UpdateStandby twice#12762cadonna merged 4 commits intoapache:trunkfrom
cadonna merged 4 commits intoapache:trunkfrom
Conversation
Member
Author
|
Could you have a look? |
cadonna
approved these changes
Oct 18, 2022
Member
|
Build failures are unrelated |
guozhangwang
pushed a commit
to guozhangwang/kafka
that referenced
this pull request
Jan 25, 2023
In two situations, the current code could transition the ChangelogReader to UpdateStandby when already in that state, causing an IllegalStateException. Namely these two cases are: 1. When only standby tasks are restoring and one of them crashes. 2. When only standby tasks are restoring and one of them is paused. This change fixes both issues by only transitioning if the paused or failed task is an active task. Reviewer: Bruno Cadonna <cadonna@apache.org>
rutvijmehta-harness
pushed a commit
to rutvijmehta-harness/kafka
that referenced
this pull request
Feb 9, 2024
In two situations, the current code could transition the ChangelogReader to UpdateStandby when already in that state, causing an IllegalStateException. Namely these two cases are: 1. When only standby tasks are restoring and one of them crashes. 2. When only standby tasks are restoring and one of them is paused. This change fixes both issues by only transitioning if the paused or failed task is an active task. Reviewer: Bruno Cadonna <cadonna@apache.org>
rutvijmehta-harness
added a commit
to rutvijmehta-harness/kafka
that referenced
this pull request
Feb 9, 2024
) In two situations, the current code could transition the ChangelogReader to UpdateStandby when already in that state, causing an IllegalStateException. Namely these two cases are: 1. When only standby tasks are restoring and one of them crashes. 2. When only standby tasks are restoring and one of them is paused. This change fixes both issues by only transitioning if the paused or failed task is an active task. Reviewer: Bruno Cadonna <cadonna@apache.org> Co-authored-by: Lucas Brutschy <lucasbru@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In two situations, the current code could transition the
ChangelogReaderto
UpdateStandbywhen already in that state, causing andInvalidStateException. Namely these two cases are:This change fixes both issues by only transitioning if the paused or
failed task is an active task.
Committer Checklist (excluded from commit message)