Skip to content

MINOR; Add accessor methods to OffsetAndEpoch#12770

Merged
jsancio merged 1 commit intoapache:trunkfrom
jsancio:minor-accessor-offset-epoch
Oct 19, 2022
Merged

MINOR; Add accessor methods to OffsetAndEpoch#12770
jsancio merged 1 commit intoapache:trunkfrom
jsancio:minor-accessor-offset-epoch

Conversation

@jsancio
Copy link
Copy Markdown
Member

@jsancio jsancio commented Oct 19, 2022

Accessor are preferred over fields because they compose better with Java's lambda syntax.

Committer Checklist (excluded from commit message)

  • Verify design and implementation
  • Verify test coverage and CI build status
  • Verify documentation (including upgrade notes)

@jsancio
MINOR; Add accessor methods to OffsetAndEpoch
237cbbe 
Accessor are preferred over fields because they compose better with Java's
lambda syntax.
@jsancio jsancio marked this pull request as ready for review October 19, 2022 16:39
@jsancio jsancio mentioned this pull request Oct 19, 2022
Merged
3 tasks
hachikuji
hachikuji approved these changes Oct 19, 2022
View reviewed changes
Copy link
Copy Markdown
Contributor

@hachikuji hachikuji left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jsancio jsancio merged commit d0ff869 into apache:trunk Oct 19, 2022
@jsancio jsancio deleted the minor-accessor-offset-epoch branch October 19, 2022 19:07
guozhangwang pushed a commit to guozhangwang/kafka that referenced this pull request Jan 25, 2023
@jsancio @guozhangwang
MINOR; Add accessor methods to OffsetAndEpoch (apache#12770)
8cb9d25 
Accessor are preferred over fields because they compose better with Java's
lambda syntax.

Reviewers: Jason Gustafson <jason@confluent.io>
rutvijmehta-harness pushed a commit to rutvijmehta-harness/kafka that referenced this pull request Feb 9, 2024
@jsancio @rutvijmehta-harness
MINOR; Add accessor methods to OffsetAndEpoch (apache#12770)
77b93aa 
Accessor are preferred over fields because they compose better with Java's
lambda syntax.

Reviewers: Jason Gustafson <jason@confluent.io>
rutvijmehta-harness added a commit to rutvijmehta-harness/kafka that referenced this pull request Feb 9, 2024
@rutvijmehta-harness @jsancio
MINOR; Add accessor methods to OffsetAndEpoch (apache#12770) (#75)
f44e94a 
Accessor are preferred over fields because they compose better with Java's
lambda syntax.

Reviewers: Jason Gustafson <jason@confluent.io>

Co-authored-by: José Armando García Sancio <jsancio@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@hachikuji hachikuji hachikuji approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@jsancio @hachikuji