MINOR: Avoid compiler warnings when registering metrics in KafkaServer#1280
Closed
Ishiihara wants to merge 4 commits into
Closed
MINOR: Avoid compiler warnings when registering metrics in KafkaServer#1280Ishiihara wants to merge 4 commits into
Ishiihara wants to merge 4 commits into
Conversation
Ishiihara
force-pushed
the
minor-warning-fix
branch
from
7c8d134 to
507325f
Compare
| val uncleanLeaderElectionRate = newMeter("UncleanLeaderElectionsPerSec", "elections", TimeUnit.SECONDS) | ||
| val leaderElectionTimer = new KafkaTimer(newTimer("LeaderElectionRateAndTimeMs", TimeUnit.MILLISECONDS, TimeUnit.SECONDS)) | ||
| def uncleanLeaderElectionRate() = newMeter("UncleanLeaderElectionsPerSec", "elections", TimeUnit.SECONDS) | ||
| def leaderElectionTimer() = new KafkaTimer(newTimer("LeaderElectionRateAndTimeMs", TimeUnit.MILLISECONDS, TimeUnit.SECONDS)) |
Member
There was a problem hiding this comment.
This is changing the semantics, we are creating a new instance each time we call these methods.
Contributor
Author
|
@ijuma Thanks for the review and offline discussion. I modified the PR according to offline discussion. and it seems the warning is gone. However, the implementation is quite Java like. |
Ishiihara
force-pushed
the
minor-warning-fix
branch
from
c91884a to
1965738
Compare
Ishiihara
changed the title
Ishiihara
changed the title
gfodor
pushed a commit
to AltspaceVR/kafka
that referenced
this pull request
Jun 3, 2016
Author: Liquan Pei <liquanpei@gmail.com> Reviewers: Ismael Juma <ismael@juma.me.uk> Closes apache#1280 from Ishiihara/minor-warning-fix
mumrah
pushed a commit
to mumrah/kafka
that referenced
this pull request
Aug 14, 2024
* Refactor share group code * Addressing review comments
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.