Skip to content

KAFKA-3636: change default max session timeout to 5 minutes#1284

Closed
hachikuji wants to merge 4 commits into
apache:trunkfrom
hachikuji:KAFKA-3636
Closed

KAFKA-3636: change default max session timeout to 5 minutes#1284
hachikuji wants to merge 4 commits into
apache:trunkfrom
hachikuji:KAFKA-3636

Conversation

@hachikuji
Copy link
Copy Markdown
Contributor

No description provided.

@guozhangwang
Copy link
Copy Markdown
Contributor

guozhangwang commented Apr 28, 2016

LGTM. cc @ijuma

EDIT: I was not careful, the patch was actually modifying the wrong config.

@hachikuji hachikuji changed the title KAFKA-3636: change default max session timeout to 3 minutes KAFKA-3636: change default max session timeout to 5 minutes Apr 28, 2016
@hachikuji
Copy link
Copy Markdown
Contributor Author

@ijuma @guozhangwang Increase the default to 5 minutes and updated the correct config this time.

@onurkaraman
Copy link
Copy Markdown
Contributor

LGTM

@ijuma
Copy link
Copy Markdown
Member

ijuma commented Apr 28, 2016

LGTM

@asfgit asfgit closed this in fdded2d Apr 28, 2016
gfodor pushed a commit to AltspaceVR/kafka that referenced this pull request Jun 3, 2016
Author: Jason Gustafson <jason@confluent.io>

Reviewers: Guozhang Wang <wangguoz@gmail.com>, Onur Karaman <okaraman@linkedin.com>, Ismael Juma <ismael@juma.me.uk>

Closes apache#1284 from hachikuji/KAFKA-3636
efeg pushed a commit to efeg/kafka that referenced this pull request May 29, 2024
mumrah pushed a commit to mumrah/kafka that referenced this pull request Aug 14, 2024
…umer (apache#1284)

* AKCORE-188: Refactor handling of Acknowledgements object in ShareConsumerImpl
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants