KAFKA-3644: Use Boolean protocol type for StopReplicaRequest delete_p…#1296
Closed
granthenke wants to merge 1 commit into
Closed
KAFKA-3644: Use Boolean protocol type for StopReplicaRequest delete_p…#1296granthenke wants to merge 1 commit into
granthenke wants to merge 1 commit into
Conversation
Contributor
|
Just to clarify, this isn't a protocol bump because the underlying byte remains the same. Correct? |
Member
Author
|
@gwenshap Yes. The underlying implementation stays the same. This is just code cleanup that improves the autogenerated protocol docs and makes sure all booleans in the protocol are implemented the same. |
Contributor
|
LGTM |
gfodor
pushed a commit
to AltspaceVR/kafka
that referenced
this pull request
Jun 3, 2016
…artitions Author: Grant Henke <granthenke@gmail.com> Reviewers: Gwen Shapira Closes apache#1296 from granthenke/stop-boolean
mumrah
pushed a commit
to mumrah/kafka
that referenced
this pull request
Aug 14, 2024
…FlightBatch (apache#1296) * Bug fix for LSO movement when ack comes for an earlier InFlightBatch * Updated the comment for the logic change
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
…artitions