Fix upgrade compatibility issue from older versions to 3.4#13130
Merged
mumrah merged 3 commits intoapache:trunkfrom Jan 19, 2023
Merged
Fix upgrade compatibility issue from older versions to 3.4#13130mumrah merged 3 commits intoapache:trunkfrom
mumrah merged 3 commits intoapache:trunkfrom
Conversation
3.4 introduced a change that requires cluster.id to be present in meta.properties if the file is available. This information is not persisted by the brokers in old versions (< 0.10). So on upgrade, the requirement check fails and halts the broker start up. Fix the requirement to ensure cluster.id is not required in zk mode on upgrade.
ijuma
reviewed
Jan 19, 2023
mumrah
approved these changes
Jan 19, 2023
Member
mumrah
left a comment
mumrah
left a comment
There was a problem hiding this comment.
Thanks @akhileshchg, LGTM. If you have it, can you paste the system test output to this PR?
mumrah
pushed a commit
that referenced
this pull request
Jan 19, 2023
#13130) 3.4 introduced a change that requires cluster.id to be present in meta.properties if the file is available. This information is not persisted by the brokers in old versions (< 0.10). So on upgrade, the requirement check fails and halts the broker start up. This patch fixes the requirement to ensure that cluster.id is not required in zk mode on upgrade. Reviewers: Ismael Juma <ismael@juma.me.uk>, Colin P. McCabe <cmccabe@apache.org>, David Arthur <mumrah@gmail.com>
guozhangwang
pushed a commit
to guozhangwang/kafka
that referenced
this pull request
Jan 25, 2023
apache#13130) 3.4 introduced a change that requires cluster.id to be present in meta.properties if the file is available. This information is not persisted by the brokers in old versions (< 0.10). So on upgrade, the requirement check fails and halts the broker start up. This patch fixes the requirement to ensure that cluster.id is not required in zk mode on upgrade. Reviewers: Ismael Juma <ismael@juma.me.uk>, Colin P. McCabe <cmccabe@apache.org>, David Arthur <mumrah@gmail.com>
TaiJuWu
pushed a commit
to TaiJuWu/kafka
that referenced
this pull request
Jan 4, 2025
apache#13130) 3.4 introduced a change that requires cluster.id to be present in meta.properties if the file is available. This information is not persisted by the brokers in old versions (< 0.10). So on upgrade, the requirement check fails and halts the broker start up. This patch fixes the requirement to ensure that cluster.id is not required in zk mode on upgrade. Reviewers: Ismael Juma <ismael@juma.me.uk>, Colin P. McCabe <cmccabe@apache.org>, David Arthur <mumrah@gmail.com>
3 tasks
chia7712
pushed a commit
that referenced
this pull request
Jan 15, 2025
Due to an issue with handling folders in Kafka version 3.3.2 (see #13130), this end-to-end test requires using a single folder for upgrade/downgrade scenarios involving 3.3.2. Reviewers: Ismael Juma <ismael@juma.me.uk>, Chia-Ping Tsai <chia7712@gmail.com>
chia7712
pushed a commit
to chia7712/kafka
that referenced
this pull request
Jan 15, 2025
Due to an issue with handling folders in Kafka version 3.3.2 (see apache#13130), this end-to-end test requires using a single folder for upgrade/downgrade scenarios involving 3.3.2. Reviewers: Ismael Juma <ismael@juma.me.uk>, Chia-Ping Tsai <chia7712@gmail.com>
chia7712
pushed a commit
that referenced
this pull request
Jan 15, 2025
Due to an issue with handling folders in Kafka version 3.3.2 (see #13130), this end-to-end test requires using a single folder for upgrade/downgrade scenarios involving 3.3.2. Reviewers: Ismael Juma <ismael@juma.me.uk>, Chia-Ping Tsai <chia7712@gmail.com>
pranavt84
pushed a commit
to pranavt84/kafka
that referenced
this pull request
Jan 27, 2025
Due to an issue with handling folders in Kafka version 3.3.2 (see apache#13130), this end-to-end test requires using a single folder for upgrade/downgrade scenarios involving 3.3.2. Reviewers: Ismael Juma <ismael@juma.me.uk>, Chia-Ping Tsai <chia7712@gmail.com>
manoj-mathivanan
pushed a commit
to manoj-mathivanan/kafka
that referenced
this pull request
Feb 19, 2025
Due to an issue with handling folders in Kafka version 3.3.2 (see apache#13130), this end-to-end test requires using a single folder for upgrade/downgrade scenarios involving 3.3.2. Reviewers: Ismael Juma <ismael@juma.me.uk>, Chia-Ping Tsai <chia7712@gmail.com>
jeqo
pushed a commit
to aiven/inkless
that referenced
this pull request
Feb 27, 2025
Due to an issue with handling folders in Kafka version 3.3.2 (see apache/kafka#13130), this end-to-end test requires using a single folder for upgrade/downgrade scenarios involving 3.3.2. Reviewers: Ismael Juma <ismael@juma.me.uk>, Chia-Ping Tsai <chia7712@gmail.com>
jeqo
pushed a commit
to aiven/inkless
that referenced
this pull request
Feb 28, 2025
Due to an issue with handling folders in Kafka version 3.3.2 (see apache/kafka#13130), this end-to-end test requires using a single folder for upgrade/downgrade scenarios involving 3.3.2. Reviewers: Ismael Juma <ismael@juma.me.uk>, Chia-Ping Tsai <chia7712@gmail.com>
apoorvmittal10
pushed a commit
to apoorvmittal10/kafka
that referenced
this pull request
Oct 17, 2025
Due to an issue with handling folders in Kafka version 3.3.2 (see apache#13130), this end-to-end test requires using a single folder for upgrade/downgrade scenarios involving 3.3.2. Reviewers: Ismael Juma <ismael@juma.me.uk>, Chia-Ping Tsai <chia7712@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
3.4 introduced a change that requires cluster.id to be present in meta.properties if the file is available. This information is not persisted by the brokers in old versions (< 0.10). So on upgrade, the requirement check fails and halts the broker start-up. Fixed the requirement to ensure cluster.id is not required in zk mode on upgrade.