Skip to content

KAFKA-14582: Move JmxTool to tools #13136

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
mimaison merged 9 commits into from
Feb 2, 2023
Merged

KAFKA-14582: Move JmxTool to tools #13136

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
9 commits
Select commit Hold shift + click to select a range
b648e19
KAFKA-14628: Move CommandLineUtils and CommandDefaultOptions shared c…
fvaleri Jan 18, 2023
e40010d
KAFKA-14582: Move JmxTool to tools
fvaleri Jan 19, 2023
a167801
Add MM feedback
fvaleri Jan 25, 2023
37b998a
Add integration test
fvaleri Jan 26, 2023
4213449
Switch back to the original class name
fvaleri Jan 27, 2023
607ff24
Minor improvements
fvaleri Jan 30, 2023
f825f87
Add changes from Mickael feedback
fvaleri Feb 1, 2023
d86dc35
Make Idea JUnit pluging happy
fvaleri Feb 1, 2023
aa99752
Remove printStackTrace()
mimaison Feb 2, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions build.gradle
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1763,6 +1763,7 @@ project(':tools') {
implementation libs.jacksonJDK8Datatypes
implementation libs.slf4jApi
implementation libs.log4j
implementation libs.joptSimple

implementation libs.jose4j // for SASL/OAUTHBEARER JWT validation
implementation libs.jacksonJaxrsJsonProvider
Expand Down
1 change: 1 addition & 0 deletions checkstyle/import-control.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -408,6 +408,7 @@
<allow pkg="org.apache.log4j" />
<allow pkg="kafka.test" />
<allow pkg="joptsimple" />
<allow pkg="javax.rmi.ssl"/>
Comment thread
fvaleri marked this conversation as resolved.
</subpackage>

<subpackage name="trogdor">
Expand Down
275 changes: 0 additions & 275 deletions core/src/main/scala/kafka/tools/JmxTool.scala
View file
Open in desktop

This file was deleted.

2 changes: 1 addition & 1 deletion tests/kafkatest/services/monitor/jmx.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -141,7 +141,7 @@ def read_jmx_output_all_nodes(self):
self.read_jmx_output(self.idx(node), node)

def jmx_class_name(self):
return "kafka.tools.JmxTool"
return "org.apache.kafka.tools.JmxTool"

class JmxTool(JmxMixin, KafkaPathResolverMixin):
"""
Expand Down
Loading