KAFKA-14659 source-record-write-[rate|total] metrics include filtered records#13193
Merged
C0urante merged 2 commits intoapache:trunkfrom Feb 28, 2023
Merged
Conversation
Contributor
|
Thank you for spotting this behaviour and contributing a fix! The proposed solution makes sense to me, I will just add @C0urante to put the appropriate tags for "connect" to this pull request and review it once it has been rebased. |
hgeraldino
force-pushed
the
sourcerecord-metrics-patch
branch
from
e85f781 to
3ba9053
Compare
hgeraldino
force-pushed
the
sourcerecord-metrics-patch
branch
from
3ba9053 to
07d4f4d
Compare
Contributor
Author
C0urante
reviewed
Feb 27, 2023
Contributor
C0urante
left a comment
C0urante
left a comment
There was a problem hiding this comment.
Thanks @hgeraldino, just one small question around potentially-unnecessary docs updates.
C0urante
approved these changes
Feb 27, 2023
Contributor
C0urante
left a comment
C0urante
left a comment
There was a problem hiding this comment.
LGTM, will merge and backport pending CI build. Thanks @hgeraldino!
C0urante
pushed a commit
that referenced
this pull request
Feb 28, 2023
…iltered records (#13193) Reviewers: Christo Lolov <christololov@gmail.com>, Chris Egerton <chrise@aiven.io>
C0urante
pushed a commit
that referenced
this pull request
Feb 28, 2023
…iltered records (#13193) Reviewers: Christo Lolov <christololov@gmail.com>, Chris Egerton <chrise@aiven.io>
rittikaadhikari
added a commit
to confluentinc/kafka
that referenced
this pull request
Feb 28, 2023
…tream-trunk-27-Feb-2023 * commit 'dcc179995153c22c6248702976b60755b0b9fda8': MINOR: srcJar should depend on processMessages task (apache#13316) KAFKA-14659 source-record-write-[rate|total] metrics should exclude filtered records (apache#13193) MINOR: ExponentialBackoff Javadoc improvements (apache#13317) KAFKA-14742: Throttle connectors in ExactlyOnceSourceIntegrationTest to fix flakey OOMEs (apache#13291)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR aligns the description for
source-record-write-rateandsource-record-write-totalmetrics, and excludes the filtered records from the metrics being published.Today, the
source-record-poll-[rate|total]andsource-record-write-[rate|total]are publishing similar values (except for cases where exceptions are thrown and retries are needed, which might throw off the rate a little bit). This means that it is not possible to find an accurate number of records written to Kafka by source connectors that use filter predicates.Committer Checklist (excluded from commit message)