MINOR: Rename IBP_3_4_IV1 as added for KIP-405 to IBP_3_5_IV0#13198
Merged
cmccabe merged 2 commits intoapache:trunkfrom Feb 6, 2023
Merged
MINOR: Rename IBP_3_4_IV1 as added for KIP-405 to IBP_3_5_IV0#13198cmccabe merged 2 commits intoapache:trunkfrom
cmccabe merged 2 commits intoapache:trunkfrom
Conversation
satishd
reviewed
Feb 4, 2023
Member
satishd
left a comment
satishd
left a comment
There was a problem hiding this comment.
Thanks @rondagostino for the PR. Please look into the failures in kafka.admin.FeatureCommandTest.
clolov
reviewed
Feb 6, 2023
| @@ -174,7 +174,7 @@ class FeatureCommandUnitTest { | |||
| @Test | |||
| def testMetadataVersionsToString(): Unit = { | |||
| assertEquals("3.3-IV0, 3.3-IV1, 3.3-IV2, 3.3-IV3, 3.4-IV0, 3.4-IV1", | |||
Contributor
There was a problem hiding this comment.
Already pointed out by @satishd, but I believe changing 3.4-IV1 to 3.5-IV0 here will make the test pass.
cmccabe
approved these changes
Feb 6, 2023
Contributor
cmccabe
left a comment
cmccabe
left a comment
There was a problem hiding this comment.
LGTM. Test failures are not related. Thanks, @rondagostino
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
#11390 will be released as part of AK 3.5 but it added the MetadataVersion
IBP_3_4_IV1. It should have beenIBP_3_5_IV0. This change causes no incompatibility because this feature is not yet released.Also,
didMetadataChangeis adjusted tofalsebecause the KRaft metadata log records are unaffected.Committer Checklist (excluded from commit message)